Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Verify all VS2013 SKUs are detected in WixVSExtension #4146

Closed
wixbot opened this Issue Oct 10, 2013 · 6 comments

Comments

Projects
None yet
2 participants
Collaborator

wixbot commented Oct 10, 2013

Not all VS SKUs shipped in RC; when all the SKUs are released at RTM, make sure they're covered.

Originally opened by barnson

Collaborator

wixbot commented Oct 19, 2013

I tested it on my machine. All registry paths, component GUIDs and file paths are same as described in \src\ext\VSExtension\wixlib\VS2013.wxs from latest (v3.8.1014.0) build of WiX 3.8

Originally posted by asvishnyakov

Collaborator

wixbot commented Oct 19, 2013

And:

  1. All Visual Studio 2013 SKUs are same as 2012, except Express for Windows Phone (not released).
  2. You need to add missing curly brackets to ComponentSearch/@Guid attribute. I don't now about ComponentSearch, but Microsoft.Deployment.WindowsInstaller.ComponentInstallation API is sensetive to its.
  3. You need to uncomment #158 line in \src\ext\VSExtension\wixlib\VS2013.wxs to support Visual Web Developer project system as part of Visual Studio Express 2013 for Web

Originally posted by asvishnyakov

Collaborator

wixbot commented Oct 19, 2013

WiX takes care of adding braces around GUIDs.

Originally posted by barnson
AssignedTo set to bobarnson

Collaborator

wixbot commented Oct 19, 2013

Pull request now available: https://wix.codeplex.com/SourceControl/network/forks/bobarnso/wixdev/contribution/5526

Originally posted by barnson

Collaborator

wixbot commented Oct 19, 2013

Oh... I don't check component paths. Old GUIDs were associated with Visual Studio 2012 versions. Sorry :(

When will be available WiX build with right Visual Studio 2013 detection?

Thank you.

Originally posted by asvishnyakov

Collaborator

wixbot commented Oct 19, 2013

Originally changed by barnson
Resolution set to fixed
Status changed from Open to Resolved

@wixbot wixbot added this to the v3.8 milestone Dec 20, 2015

@wixbot wixbot closed this Dec 20, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment