New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ExePackage/ExitCode/@Value is stored as signed but HRESULTs aren't signed #4319

Closed
wixbot opened this Issue Feb 18, 2014 · 6 comments

Comments

Projects
None yet
2 participants
@wixbot
Collaborator

wixbot commented Feb 18, 2014

Right now, an HRESULT as an exit code turns into a negative but Burn tries to read the values as DWORDs and fails.

Originally opened by barnson

@wixbot

This comment has been minimized.

Collaborator

wixbot commented Feb 27, 2014

Managed side uses signed integer in the authoring->unreal table->manifest. We need to get all 32 bits usable to match the DWORD process exit code.

@wixbot

This comment has been minimized.

Collaborator

wixbot commented Jun 6, 2014

Originally changed by firegiantco
AssignedTo set to firegiant

@wixbot

This comment has been minimized.

Collaborator

wixbot commented Jun 6, 2014

We'd like to get the fix for this into WiX v3.9 if possible. We have a fix localized to a single line change in the Binder.cs file to ensure the signed integers are written as unsigned (as the Burn engine expects).

Originally posted by firegiantco
Status changed from Open to Untriaged

@wixbot

This comment has been minimized.

Collaborator

wixbot commented Jun 6, 2014

Pull away. A one-liner sounds interesting.

Originally posted by barnson
Release changed from v3.x to v3.9

@wixbot

This comment has been minimized.

Collaborator

wixbot commented Jun 6, 2014

Fixed by pull request: wixtoolset/wix3#61

Originally posted by firegiantco

@wixbot

This comment has been minimized.

Collaborator

wixbot commented Jun 7, 2014

Should be fixed in next build.

Originally posted by firegiantco
Resolution set to fixed
Status changed from Open to Resolved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment