Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

WiX compiler allows building MSI with 4th version index larger than 65535 #4443

Closed
wixbot opened this Issue Jun 9, 2014 · 5 comments

Comments

Projects
None yet
2 participants
Collaborator

wixbot commented Jun 9, 2014

Reproduction steps:

  • in Visual Studio, start a new Setup Project
  • change the version attribute in the product element to "1.0.0.65536"
  • build
    • Note there is no compile error

Each version index should be 16-bit unsigned, as described here: http://msdn.microsoft.com/en-us/library/aa372488%28v=vs.85%29.aspx

This becomes a problem if you try to chain an MSI created in such a manner using Burn. Burn will compile the application, but on execution the bootstrapper will error with the following message in the Setup*.txt log dumped to AppData:
[25C4:25D0][2014-06-09T14:24:10]i001: Burn v3.8.1128.0, Windows v6.3 (Build 9600: Service Pack 0), path:

C:\Users\ejcarpen\Documents\Visual Studio 2010\Projects\Bootstrapper1\Bootstrapper1\bin\Debug\Bootstrapper1.exe, cmdline: ''
[25C4:25D0][2014-06-09T14:24:10]e000: Error 0x8002000a: Failed to parse @Version: 1.0.0.65536
[25C4:25D0][2014-06-09T14:24:10]e000: Error 0x8002000a: Failed to parse MSI package.
[25C4:25D0][2014-06-09T14:24:10]e000: Error 0x8002000a: Failed to parse packages.
[25C4:25D0][2014-06-09T14:24:10]e000: Error 0x8002000a: Failed to load manifest.
[25C4:25D0][2014-06-09T14:24:10]e000: Error 0x8002000a: Failed to initialize core.

Bootstrapper cannot parse the MSI file, since it was created with an illegal version number

Originally opened by betteroffed

Collaborator

wixbot commented Jun 12, 2014

If >65535 is accepted at MSI (i.e., if it installs successfully), then Burn should either error at bind time or truncate at 65535 and warn at bind time that upgrades won't work as expected.

Release changed from v3.8 to v3.9

Collaborator

wixbot commented Jun 12, 2014

MSI will install and upgrade packages with ProductVersions of, for example, 1.0.0.65536 and 1.0.1.95536.

Originally posted by barnson
Status changed from Open to Untriaged

Collaborator

wixbot commented Jun 12, 2014

Originally changed by barnson
AssignedTo set to bobarnson

Collaborator

wixbot commented Jun 13, 2014

wixtoolset/wix3#65

Originally posted by barnson

Collaborator

wixbot commented Jun 13, 2014

Originally changed by barnson
Resolution set to fixed
Status changed from Open to Resolved

@wixbot wixbot added this to the v3.9 milestone Dec 20, 2015

@wixbot wixbot closed this Dec 20, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment