Heat should escape dollar signs ($$) in file names #4562

Closed
wixbot opened this Issue Oct 20, 2014 · 6 comments

Comments

Projects
None yet
1 participant
@wixbot
Collaborator

wixbot commented Oct 20, 2014

When harvesting the file AuthController$$TestAuthParams.html, heat generates this component:

<File Id="fil50E06941A55A672424B7E311B8A289FC" KeyPath="yes" Source="$(var.WebAppSource)\share\doc\api\controllers\AuthController$$TestAuthParams.html" />

Light interprets the filename as AuthController$TestAuthParams.html, resulting in a LGHT0103 error (file not found).

Heat should instead escape $$ to $$$$ according to the docs:

The preprocessor treats the $ character in a special way if it is followed by a $ or (. If you want to use a literal $$, use $$$$ instead. Every two $ characters will be replaced with one. For example, $$$$$ will be replaced with $$$.

Originally opened by dwickern

@wixbot

This comment has been minimized.

Show comment
Hide comment
@wixbot

wixbot Oct 23, 2014

Collaborator

Release changed from v3.8 to v3.x

Collaborator

wixbot commented Oct 23, 2014

Release changed from v3.8 to v3.x

@wixbot

This comment has been minimized.

Show comment
Hide comment
@wixbot

wixbot Nov 3, 2014

Collaborator

Why is this a bug. According to the Quote you used for Reference: Every two $ characters will be replaced with one. The pre-processor is behaving as expected, with respect to the documented behavior. Would it dot be easier to have heat ignore Filenames with special characters. I'll try and tackle this one but implementimg a count of special characters will be tough.

Originally posted by eyoung100

Collaborator

wixbot commented Nov 3, 2014

Why is this a bug. According to the Quote you used for Reference: Every two $ characters will be replaced with one. The pre-processor is behaving as expected, with respect to the documented behavior. Would it dot be easier to have heat ignore Filenames with special characters. I'll try and tackle this one but implementimg a count of special characters will be tough.

Originally posted by eyoung100

@wixbot

This comment has been minimized.

Show comment
Hide comment
@wixbot

wixbot Nov 4, 2014

Collaborator

The preprocessor behaves as expected, the problem is heat. The original file name had two $ characters and heat generated a component with only one $ according do the preprocessor escaping rules.

I opened a PR wixtoolset/wix3#163

Originally posted by dwickern

Collaborator

wixbot commented Nov 4, 2014

The preprocessor behaves as expected, the problem is heat. The original file name had two $ characters and heat generated a component with only one $ according do the preprocessor escaping rules.

I opened a PR wixtoolset/wix3#163

Originally posted by dwickern

@wixbot

This comment has been minimized.

Show comment
Hide comment
@wixbot

wixbot Nov 4, 2014

Collaborator

Since you submitted a pull request for the $, you should test the other special characters, if there are any.

Originally posted by eyoung100

Collaborator

wixbot commented Nov 4, 2014

Since you submitted a pull request for the $, you should test the other special characters, if there are any.

Originally posted by eyoung100

@wixbot

This comment has been minimized.

Show comment
Hide comment
@wixbot

wixbot Dec 5, 2014

Collaborator

wixtoolset/wix3#163

Originally posted by barnson
AssignedTo set to dwickern
Resolution set to fixed
Status changed from Open to Resolved

Collaborator

wixbot commented Dec 5, 2014

wixtoolset/wix3#163

Originally posted by barnson
AssignedTo set to dwickern
Resolution set to fixed
Status changed from Open to Resolved

@wixbot

This comment has been minimized.

Show comment
Hide comment
@wixbot

wixbot Dec 5, 2014

Collaborator

Originally changed by barnson
Release changed from v3.x to v3.10

Collaborator

wixbot commented Dec 5, 2014

Originally changed by barnson
Release changed from v3.x to v3.10

@wixbot wixbot added bug heat labels Dec 20, 2015

@wixbot wixbot added this to the v3.10 milestone Dec 20, 2015

@wixbot wixbot closed this Dec 20, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment