Disabling Burn Logging via Log Element still creates MSI-Logs with "cryptic" filenames #4571

Closed
wixbot opened this Issue Oct 27, 2014 · 3 comments

Comments

Projects
None yet
1 participant
Collaborator

wixbot commented Oct 27, 2014

When trying to completely disable logging of a burn based bootstrapper using the Log Element
something strange happens. Instead of also disabling the logging that takes place in the MSIs,
log-files are created in the current-directory of the running bootstrapper executable.

The files created take the form:


(null)_0_MSI_PACKAGE_ID1.(null)

(null)1_MSI_PACKAGE_ID2.(null)

...

(null)
[n]_MSI_PACKAGE_ID[n+1].(null)

I have created a temporary fix that involves changing the function LoggingSetPackageVariable
in logging.cpp. Checking the log-state to make sure logging is not disabled prior to creating
the logging filename used for the respective msis makes sure that no log is created if not
intended:

if ( BURN_LOGGING_STATE_DISABLED == pLog->state ) {

     if ( psczLogPath ) {

         *psczLogPath = NULL;

     }

    goto LExit;

}

Originally opened by info

Collaborator

wixbot commented Oct 30, 2014

Release changed from v3.x to v3.10

Collaborator

wixbot commented Oct 30, 2014

AssignedTo set to info@tobias-erichsen.de

Collaborator

wixbot commented Jan 30, 2015

f4cdf9a8b127b16c9430e9e01393084931ef7359

Originally posted by barnson
Resolution set to fixed
Status changed from Open to Resolved

@wixbot wixbot added bug burn labels Dec 20, 2015

wixbot added this to the v3.10 milestone Dec 20, 2015

wixbot closed this Dec 20, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment