Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Duplicated code in Votive2013.pkgdef #4611

Closed
wixbot opened this Issue Nov 29, 2014 · 4 comments

Comments

Projects
None yet
2 participants
Collaborator

wixbot commented Nov 29, 2014

Seemst that everithing after the line 86 in the file \src\Votive\votive2013\Votive2013.pkgdef is duplicated (a copy of initial 86 lines.

Is that a miss or is there a reason why in the first try pkgdef will not write that values in the registry?

Thanks

Originally opened by mario.majcica

Collaborator

wixbot commented Dec 4, 2014

AssignedTo set to bobarnson
Release changed from v3.9 to v3.10

Collaborator

wixbot commented Feb 1, 2015

wixtoolset/wix3#197

Originally posted by barnson

Collaborator

wixbot commented Feb 4, 2015

9e940f66d9bccdc1cd9e653ef28504ba51d6206b

Actually, Votive2013.pkgdef isn't used (yet?) so the change is against Votive2010.pkgdef.

Originally posted by barnson

Collaborator

wixbot commented Feb 4, 2015

Originally changed by barnson
Resolution set to fixed
Status changed from Open to Resolved

@wixbot wixbot added this to the v3.10 milestone Dec 20, 2015

@wixbot wixbot closed this Dec 20, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment