Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Several pre-initialized built-in variables do not resolve when used in MsiProperty values #4630

Closed
wixbot opened this Issue Dec 20, 2014 · 8 comments

Comments

Projects
None yet
2 participants
Collaborator

wixbot commented Dec 20, 2014

Given

<Variable bal:Overridable="yes" Name="INSTALLDIR" Value="[ProgramFilesFolder][WixBundleManufacturer]\[WixBundleName]" />
<Variable Name="FOO" Value="[WixBundleProviderKey]-[WixBundleTag]-[WixBundleVersion]" />

<Chain>
    <MsiPackage SourceFile="$(var.SetupProject1.TargetPath)">
        <MsiProperty Name="INSTALLDIR" Value="[INSTALLDIR]"/>
        <MsiProperty Name="FOO" Value="[FOO]"/>
        <MsiProperty Name="BAR" Value="[WixBundleProviderKey]-[WixBundleTag]-[WixBundleVersion]"/>
    </MsiPackage>
</Chain>

The pre-initialized variables resolve to their zero/empty/null values:

[0BBC:0A94][2014-12-19T21:51:12]i301: Applying execute package: SetupProject1.msi, action: Install, path: C:\ProgramData\Package Cache\{E8EB1A3A-C5A3-4120-85D5-EDF0CE165BB7}v1.0.0.0\SetupProject1.msi, arguments: ' ARPSYSTEMCOMPONENT="1" MSIFASTINSTALL="7" INSTALLDIR="C:\Program Files (x86)\\Bootstrapper1" FOO="--0.0.0.0" BAR="--0.0.0.0"'

but do show up in the variable dump:

[1090:06A8][2014-12-19T21:51:15]i410: Variable: WixBundleManufacturer = FireGiant
[1090:06A8][2014-12-19T21:51:15]i410: Variable: WixBundleName = Bootstrapper1
[1090:06A8][2014-12-19T21:51:15]i410: Variable: WixBundleProviderKey = {b5bb7f9f-a5bb-43f1-99fe-b122308d2fa0}
[1090:06A8][2014-12-19T21:51:15]i410: Variable: WixBundleTag = 
[1090:06A8][2014-12-19T21:51:15]i410: Variable: WixBundleVersion = 1.0.0.0

However, the problem occurs only with a per-machine bundle. A per-user bundle works as expected:

[145C:1568][2014-12-19T22:04:37]i301: Applying execute package: SetupProject1.msi, action: Install, path: C:\Users\Barnson\AppData\Local\Package Cache\{C97C24AD-9377-453F-83EE-72B20FCAD548}v1.0.0.0\SetupProject1.msi, arguments: ' ARPSYSTEMCOMPONENT="1" MSIFASTINSTALL="7" INSTALLDIR="C:\Program Files (x86)\FireGiant\Bootstrapper1" FOO="{2e3e60db-d87d-49f7-b94c-4eba2ae741ba}--1.0.0.0" BAR="{2e3e60db-d87d-49f7-b94c-4eba2ae741ba}--1.0.0.0"'

This repros back to WiX v3.8.

Originally opened by barnson

Collaborator

wixbot commented Dec 20, 2014

I checked WiX v3.8, v3.9, v3.9 R2 RC, and v3.10.1124.0.

Originally posted by barnson

Collaborator

wixbot commented Dec 20, 2014

Duplicate of 4211

Originally posted by rseanhall

Collaborator

wixbot commented Jan 8, 2015

AssignedTo set to bobarnson
Release changed from v3.x to v3.10

Collaborator

wixbot commented Mar 3, 2015

AssignedTo changed from bobarnson to shall

Collaborator

wixbot commented Mar 29, 2015

v3 pull request: 225

v4 pull request: 114

Originally posted by rseanhall

Collaborator

wixbot commented Apr 15, 2015

Updated wix3 pull request: 228

Originally posted by rseanhall
Resolution set to fixed
Status changed from Open to Resolved

Collaborator

wixbot commented Aug 18, 2015

Resolution changed from fixed to
Statuschanged fromResolvedtoOpen

Collaborator

wixbot commented Aug 25, 2015

Security reaction pull request: 290

Originally posted by rseanhall
Resolution set to fixed
Status changed from Open to Resolved

@wixbot wixbot added bug burn labels Dec 20, 2015

@wixbot wixbot added this to the v3.10 milestone Dec 20, 2015

@wixbot wixbot closed this Dec 20, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment