util:FileShare fails to create a network share for a whole drive (ie root folder) #4646

Closed
wixbot opened this Issue Jan 6, 2015 · 4 comments

Comments

Projects
None yet
2 participants
Collaborator

wixbot commented Jan 6, 2015

The problem occurs as when a root directory is entered such as "c:" the trailing backlash is removed.
NetShareAdd() called by CreateShare() in scasmbexec.cpp requires this trailing backslash to share the whole drive. However, ScaSmbRead() in scasmbsched.cpp at line 230 removes the trailing backslash even for a root directory:
"// remove trailing backslash"

Originally opened by greggc

Collaborator

wixbot commented Jan 8, 2015

Release changed from v3.9 to v3.x

Collaborator

wixbot commented Feb 9, 2015

Originally changed by rseanhall
AssignedTo set to shall

Collaborator

wixbot commented Feb 9, 2015

3.10 pull request: 205

4.0 pull request: 93

Originally posted by rseanhall
Release changed from v3.x to v3.10

Collaborator

wixbot commented Feb 10, 2015

Thanks for locating the problem.

Originally posted by rseanhall
Resolution set to fixed
Status changed from Open to Resolved

rseanhall was assigned by wixbot Dec 20, 2015

wixbot added this to the v3.10 milestone Dec 20, 2015

wixbot closed this Dec 20, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment