Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace Win64 Attribute with a new attribute 'Bitness' #4707

Closed
wixbot opened this issue Mar 18, 2015 · 3 comments · Fixed by wixtoolset/Util.wixext#38
Closed

Replace Win64 Attribute with a new attribute 'Bitness' #4707

wixbot opened this issue Mar 18, 2015 · 3 comments · Fixed by wixtoolset/Util.wixext#38
Assignees
@robmen @Mike-GC
Labels
compiler feature FourOhPreviewZero
Projects
wix.4.0-preview.0
Milestone
v4.0

Comments

@wixbot
Copy link

wixbot commented Mar 18, 2015

Right now Win64='yes' is pretty much useless unless you want to break your build on 32-bit. Instead, let's create an attribute that doesn't rely on "candle.exe -arch" to do the right thing, and has two useful values "yes" and "no" are both sane values. "no" would be the default.

WIP pull request here: https://github.com/wixtoolset/site/pull/47

Originally opened by mike
@wixbot
Copy link
Author

wixbot commented Mar 18, 2015

Pull request for WIP submitted: https://github.com/wixtoolset/site/pull/47

Originally posted by mike

@wixbot
Copy link
Author

wixbot commented Mar 24, 2015

AssignedTo set to mikegc

@wixbot wixbot added this to the v4.0 milestone Dec 20, 2015
@rseanhall rseanhall added this to To do in wix.4.0-preview.0 Nov 16, 2020
@rseanhall
Copy link
Contributor

wixtoolset/wix#117

@robmen robmen changed the title Replace Win64 Attribute with a new attribute named similar to 'Always32Bit' Replace Win64 Attribute with a new attribute 'Bitness' Feb 11, 2021
This was referenced Feb 11, 2021
Merged
Merged
wix.4.0-preview.0 automation moved this from To do to Done Feb 11, 2021
@robmen robmen mentioned this issue Feb 11, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@robmen robmen

@Mike-GC Mike-GC

Labels
compiler feature FourOhPreviewZero
Projects
No open projects
wix.4.0-preview.0
  
Done
Milestone
v4.0
Development

Successfully merging a pull request may close this issue.

Replace Win64 attribute with Bitness attribute wixtoolset/Util.wixext
5 participants
@robmen @barnson @rseanhall @wixbot @Mike-GC