Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Burn variable strings should support a "literal" flag to handle strings that contain embedded brackets #4763

Closed
wixbot opened this Issue May 15, 2015 · 3 comments

Comments

Projects
None yet
2 participants
Collaborator

wixbot commented May 15, 2015

Square brackets ([ and ]) are legal characters for file names, but are also used to denote Burn Variables. This means that if the value of WixBundleOriginalSource (or other built-in variables for paths) is set to a file name with an opening and closing square bracket, like C:/MyTestFolder/Some[Missing]Data/Install.exe, formatting it in something like InstallCommand won't work properly - either it will be replaced by the value of the Missing variable or an empty string if it doesn't exist.

Originally opened by rseanhall

Collaborator

wixbot commented May 19, 2015

For v3.x, we can set it from searches (file system, registry) where this might be a problem. For v4.x, we can evaluate if we need to expose the literal flag as a flag or new variable type.

AssignedTo set to shall
Type changed from Bug to Feature

Collaborator

wixbot commented May 22, 2015

v3.10 pull request: 252

Originally posted by rseanhall

Collaborator

wixbot commented May 24, 2015

Originally changed by rseanhall
Resolution set to fixed
Status changed from Open to Resolved

@wixbot wixbot added this to the v3.10 milestone Dec 20, 2015

@wixbot wixbot closed this Dec 20, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment