WixStdBA should use ShelExecUnelevated to open hyperlinks #4772

Closed
wixbot opened this Issue May 22, 2015 · 5 comments

Comments

Projects
None yet
2 participants
@wixbot
Collaborator

wixbot commented May 22, 2015

Given that a BA might run elevated (explicit elevation, requireAdministrator manifesting) hyperlinks should be opened unelevated so an unsuspecting user isn't running a browser elevated.

Originally opened by barnson

@wixbot

This comment has been minimized.

Show comment
Hide comment
@wixbot

wixbot May 26, 2015

Collaborator

Originally changed by barnson
AssignedTo set to bobarnson
Resolution set to fixed
Status changed from Untriaged to Resolved

Collaborator

wixbot commented May 26, 2015

Originally changed by barnson
AssignedTo set to bobarnson
Resolution set to fixed
Status changed from Untriaged to Resolved

@wixbot

This comment has been minimized.

Show comment
Hide comment
@wixbot

wixbot Oct 9, 2015

Collaborator

Effects of replacement from ShellExec to ShelExecUnelevated leads to the fact that links on Windows XP stop working at all.
Reason: Flag SWC_DESKTOP method IShellWindows :: FindWindowSW not supported on Windows XP. (https://msdn.microsoft.com/en-us/library/windows/desktop/cc836568(v=vs.85).aspx)

Originally posted by pavelanfimov

Collaborator

wixbot commented Oct 9, 2015

Effects of replacement from ShellExec to ShelExecUnelevated leads to the fact that links on Windows XP stop working at all.
Reason: Flag SWC_DESKTOP method IShellWindows :: FindWindowSW not supported on Windows XP. (https://msdn.microsoft.com/en-us/library/windows/desktop/cc836568(v=vs.85).aspx)

Originally posted by pavelanfimov

@wixbot

This comment has been minimized.

Show comment
Hide comment
@wixbot

wixbot Oct 9, 2015

Collaborator

Originally changed by barnson
Status changed from Resolved to Untriaged

Collaborator

wixbot commented Oct 9, 2015

Originally changed by barnson
Status changed from Resolved to Untriaged

@wixbot

This comment has been minimized.

Show comment
Hide comment
@wixbot

wixbot Oct 9, 2015

Collaborator

see wixtoolset/wix3#307

Originally posted by pavelanfimov

Collaborator

wixbot commented Oct 9, 2015

see wixtoolset/wix3#307

Originally posted by pavelanfimov

@wixbot

This comment has been minimized.

Show comment
Hide comment
@wixbot

wixbot Oct 13, 2015

Collaborator

Status changed from Untriaged to Resolved
Type changed from Feature to Bug

Collaborator

wixbot commented Oct 13, 2015

Status changed from Untriaged to Resolved
Type changed from Feature to Bug

@wixbot wixbot added this to the v3.10 milestone Dec 20, 2015

@wixbot wixbot closed this Dec 20, 2015

rseanhall added a commit to rseanhall/wix4 that referenced this issue Mar 19, 2016

fix hyperlinks works on Windows XP
fix ShelExecUnelevated method

Addresses wixtoolset/issues#4772

robmen added a commit to wixtoolset/wix4 that referenced this issue Mar 22, 2016

fix hyperlinks works on Windows XP
fix ShelExecUnelevated method

Addresses wixtoolset/issues#4772
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment