Poor choice of MediaTemplate/@CabinetTemplate can result in the cab file being written to a COM port #4797

Closed
wixbot opened this Issue Jun 13, 2015 · 2 comments

Comments

Projects
None yet
2 participants
@wixbot
Collaborator

wixbot commented Jun 13, 2015

Writing cabinet files does not appear to check the resulting device is actually a file. For example if you declare <MediaTemplate CabinetTemplate="Com{0}.cab"> and you have communication port COM1 present on your PC, the entire cabinet file is written to the communication port COM1.

Originally opened by rbradford

@wixbot

This comment has been minimized.

Show comment
Hide comment
@wixbot

wixbot Jun 16, 2015

Collaborator

AssignedTo set to robmen
Release changed from v3.9 to v3.11

Collaborator

wixbot commented Jun 16, 2015

AssignedTo set to robmen
Release changed from v3.9 to v3.11

@wixbot

This comment has been minimized.

Show comment
Hide comment
@wixbot

wixbot Jun 17, 2015

Collaborator

Type changed from Bug to Feature

Collaborator

wixbot commented Jun 17, 2015

Type changed from Bug to Feature

@wixbot wixbot added this to the v3.11 milestone Dec 20, 2015

robmen added a commit to robmen/wix3 that referenced this issue Feb 1, 2017

Protect against use of reserved file names
Windows has a set of reserved file names such as `CON`, `NUL`, `COM1`,
`LPT2`. Creating files with those names will result in all sorts of
undesirable behavior, the most common is that that the build hangs.
Now we'll catch use of reserved names and print out a helpful error
message.

Fixes wixtoolset/issues#4797

@robmen robmen referenced this issue in wixtoolset/wix3 Feb 1, 2017

Merged

Protect against use of reserved file names #394

robmen added a commit to robmen/wix3 that referenced this issue Feb 1, 2017

Protect against use of reserved file names
Windows has a set of reserved file names such as `CON`, `NUL`, `COM1`,
`LPT2`. Creating files with those names will result in all sorts of
undesirable behavior, the most common is that that the build hangs.
Now we'll catch use of reserved names and print out a helpful error
message.

Fixes wixtoolset/issues#4797

rseanhall added a commit to rseanhall/wix4 that referenced this issue Feb 19, 2017

Protect against use of reserved file names
Windows has a set of reserved file names such as `CON`, `NUL`, `COM1`,
`LPT2`. Creating files with those names will result in all sorts of
undesirable behavior, the most common is that that the build hangs.
Now we'll catch use of reserved names and print out a helpful error
message.

Fixes wixtoolset/issues#4797
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment