New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Layout to custom directory doesn't copy bundle payload #5277

Closed
res2k opened this Issue Apr 27, 2016 · 4 comments

Comments

Projects
None yet
4 participants
@res2k

res2k commented Apr 27, 2016

When letting Burn layout to a directory other than the default (i.e. using SetVariableString (L"WixBundleLayoutDirectory", ...)) the bundle is copied from the clean room, i.e. any payload is missing.

  • Which version of WiX are you building with?

3.10.3 (built from wix3103 branch)

  • Which version of Visual Studio are you building with (if any)?

VS 2013 Update 1

  • Which version of .NET are you building with?

n/a

  • If the problem occurs when installing your packages built with WiX, what is the version of Windows the package is running on?

Windows 7

  • Describe the problem and the steps to reproduce it.

The bootstrapper application needs to set the WixBundleLayoutDirectory variable to some value other than the default. When performing the layout the engine will then copy the bundle executable from the clean room (the copied file is smaller than it should be; it's also clear from the logs).

  • Describe the behavior you expected and how it differed from the actual behavior.

The engine should copy the bundle executable from the original source path so it includes all payloads.

@BMurri

This comment has been minimized.

Show comment
Hide comment
@BMurri

BMurri Mar 6, 2017

Collaborator

Does this issue need to be ported to wix4?

Collaborator

BMurri commented Mar 6, 2017

Does this issue need to be ported to wix4?

@rseanhall

This comment has been minimized.

Show comment
Hide comment
@rseanhall

rseanhall Mar 6, 2017

Member

I cherry picked it into wix4 - wixtoolset/wix4#216

Member

rseanhall commented Mar 6, 2017

I cherry picked it into wix4 - wixtoolset/wix4#216

@BMurri

This comment has been minimized.

Show comment
Hide comment
@BMurri

BMurri Mar 6, 2017

Collaborator

Then it appears this bug needs to be closed as fixed

Collaborator

BMurri commented Mar 6, 2017

Then it appears this bug needs to be closed as fixed

@rseanhall rseanhall closed this Mar 6, 2017

@rseanhall

This comment has been minimized.

Show comment
Hide comment
@rseanhall

rseanhall Mar 6, 2017

Member

yep, thanks

Member

rseanhall commented Mar 6, 2017

yep, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment