Burn built-in SystemFolder and System64Folder properties reversed #5307

Closed
RGBradford opened this Issue May 26, 2016 · 1 comment

Comments

Projects
None yet
4 participants
@RGBradford

In WIX 3.10.2, the values of the Burn SystemFolder and System64Folder built-in properties are reversed when compared to similar properties in Windows Installer.

In Windows Installer, the built-in property SystemFolder typically resolves to C:\Windows\System32 on 32 bit operating systems and C:\Windows\SysWow64 on 64 bit operating systems. In Burn the SystemFolder property always resolves to C:\Windows\System32.

In Windows Installer, the built-in property System64Folder typically resolves to C:\Windows\System32 on 64 bit operating systems and is not used on 32 bit operating systems. In Burn the System64Folder property resolves to C:\Windows\SysWow64 on 64 bit operating systems.

This makes detecting the presence of 32 bit files in Burn more complicated than necessary, For example to detect the presence of the 32 bit file in a system folder requires two util:FileSearch elements:

<util:FileSearch Id="FileExistsOnX64" Condition="VersionNT64" Variable="myFileExists" Path="[System64Folder]MyFile.dll" Result="exists"/>
<util:FileSearch Id="FileExistsOnX86" Condition="NOT VersionNT64" Variable="myFileExists" Path="[SystemFolder]MyFile.dll" Result="exists"/>

@barnson barnson added this to the v3.11 milestone Jun 7, 2016

@phillHgl

This comment has been minimized.

Show comment
Hide comment
@phillHgl

phillHgl Jun 7, 2016

I did not see where System64Folder is documented as a Burn Variable in the chm. I did see it in the source.

phillHgl commented Jun 7, 2016

I did not see where System64Folder is documented as a Burn Variable in the chm. I did see it in the source.

@barnson barnson added the burn label Jun 11, 2016

robmen added a commit to robmen/wix3 that referenced this issue Feb 18, 2017

Correctly set and document SystemFolder and System64Folder in Burn
The values for SystemFolder and System64Folder were all mixed up. This
Fixes that then adds missing and fixes existing documentation about
these two Burn variables.

Fixes wixtoolset/issues#5307

@robmen robmen referenced this issue in wixtoolset/wix3 Feb 18, 2017

Closed

Fix 5265 and 5307 #411

robmen added a commit to robmen/wix3 that referenced this issue Feb 18, 2017

Correctly set and document SystemFolder and System64Folder in Burn
The values for SystemFolder and System64Folder were all mixed up. This
Fixes that then adds missing and fixes existing documentation about
these two Burn variables.

Fixes wixtoolset/issues#5307

robmen added a commit to robmen/wix4 that referenced this issue Feb 26, 2017

Correctly set and document SystemFolder and System64Folder in Burn
The values for SystemFolder and System64Folder were all mixed up. This
Fixes that then adds missing and fixes existing documentation about
these two Burn variables.

Fixes wixtoolset/issues#5307
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment