WiX v4.0 compiler crashes with invalid ids #5464

Open
barnson opened this Issue Dec 29, 2016 · 0 comments

Projects

None yet

1 participant

@barnson
Member
barnson commented Dec 29, 2016
  • Which version of WiX are you building with?

wix4/develop@HEAD

  • Which version of .NET are you building with?

4.6.2 on Windows 8.1

  • Describe the problem and the steps to reproduce it.

Given code like:

<Component Id="@#$" Guid="{2F18F52A-9E24-4ebe-A5FC-974089AA03D2}" Directory="WixTestFolder">
  <CreateFolder Directory="WixTestFolder"/>
</Component>

The compiler crashes with

candle.exe : error CNDL0001 : Object reference not set to an instance of an object.

Exception Type: System.NullReferenceException

Stack Trace:
   at WixToolset.Compiler.ParseComponentElement(XElement node, ComplexReferenceParentType parentType, String parentId, String parentLanguage, Int32 diskId, String directoryId, String srcPath) in Z:\src\wix4dev\src\tools\wix\Compiler.cs:line 2321
   at WixToolset.Compiler.ParseComponentGroupElement(XElement node, ComplexReferenceParentType parentType, String parentId) in Z:\src\wix4dev\src\tools\wix\Compiler.cs:line 2623
   at WixToolset.Compiler.ParseProductElement(XElement node) in Z:\src\wix4dev\src\tools\wix\Compiler.cs:line 11953
   at WixToolset.Compiler.ParseWixElement(XElement node) in Z:\src\wix4dev\src\tools\wix\Compiler.cs:line 20571
   at WixToolset.Compiler.Compile(XDocument source) in Z:\src\wix4dev\src\tools\wix\Compiler.cs:line 191
   at WixToolset.Tools.Candle.Run() in Z:\src\wix4dev\src\tools\candle\candle.cs:line 190
   at WixToolset.Tools.Candle.Execute(String[] args) in Z:\src\wix4dev\src\tools\candle\candle.cs:line 65
  • Describe the behavior you expected and how it differed from the actual behavior.

I'd expect an error about the invalid id and a lack of crashing.

@barnson barnson referenced this issue in wixtoolset/wix4 Dec 29, 2016
Merged

Some fixes for wix4 tests #224

@barnson barnson added this to the v4.0 milestone Jan 3, 2017
@barnson barnson added the tests label Jan 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment