Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Catastrophic failure from Torch utility #5485
We're switching to WiX patching from msidiff/msimsp. We need to use melt.exe to correct the source image because our build tree will not be available during our patch build.
Our melt command is:
melt.exe "$(LOCAL_PREV_MSI)" -out "$(OUTDIR)$(BINFILE:B)Corrected.wixpdb" -pdb "$(PATCH_TARGET_PATH)$(PACKAGE_DIR)\pdbs$(BINFILE:B).wixpdb" -x "$(TIER_ROOT:s-/--)\gen$(TARGET)$(PATCH_BASENAME)\P00Bits" $(MELT_OUTPUT)
Running: torch.exe -p -xi ReleasePatch\XYZCorrected.wixpdb D:\builds\xyz_team_ref.pyro.systest\pub\gen\install\packages\Release\pdbs\XYZ.wixpdb -out ReleasePatch\DefaultPatchDiff.wixmst
I would expect torch to perform the diff and output the .wixmst file for consumption by pyro. I'm taking a guess as this could be a cabinet size issue, but currently with msimsp.exe our patch cabinet is less than 2GB uncompressed so this should work.
Thanks Bob for replying. Big fan of your work. I'll try updating to 3.10 early next week to see. I wouldn't so much consider our build custom. It's the stock download, with a few tweaks made and fed into MSBuild (eg: we like to default component bits such as transitive without having to re-author over 10,000 wxs files). When you mention 3.10, I did notice you had a change in that minor upgrade to address 2 places that were incorrectly checking for a null string. I've incorporated those into our build of 3.7 to get past the initial issue we saw with Torch (thanks for that fix too). However, I will get the stock drop of 3.10 if you believe that will help matters and are thinking of other things outside of your fix for the null strings.…
________________________________ From: Bob Arnson <email@example.com> Sent: Friday, February 3, 2017 12:47:46 PM To: wixtoolset/issues Cc: Miles, Chad; Author Subject: Re: [wixtoolset/issues] Catastrophic failure from Torch utility (#5485) As you're using a custom build of WiX, are you able to reproduce the problem with a current version (3.10.3) of stock WiX tools? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub<#5485 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/ALhzVWULf307Y2KzIyiIGQQ_a17EpPG1ks5rY2hCgaJpZM4L2jl2>.
Sorry I read the first part of your reply incorrectly and thought you asked "Are you using a custom build". I should say we are then, as I'm guessing you're seeing the fact we got past the null string error. :)
But that's about it, we don't customize much further than what's mentioned. We do have a way to use legacy patching since this only affects 1 install, our largest install, out of many. And we can release future upgrades and patches for that one product the 'legacy' way and can use WiX patching for everything else. We're trying to move towards speeding up builds and building patches in parallel without needing mutexes for admin installs/msimsp.
It looks like upgrading to WiX 3.11 solved all our problems. We don't have to bind files with light first and can rely on melt for handling the Binary/Module table for us, and also we're able to build our largest patch and not hit that catastrophic error message. Awesome, thanks Bob!
I do have a few final questions, which I can post over on Nabble if you prefer.
Is this something that was new to WiX 3.11 or was it in a prior update for say 3.8/3.9/3.10? What I'm getting at is I'd love to see a way to get the changes in 3.11 but without having to run the sn command line for the build init step.
If it's not possible and all the changes for the 2 issues I was running into (binary/module/icon table extraction + that cab size catastrophic failure) were addressed initially in 3.11, and I have to work with the strong-naming validation process for WiX, are there other ways to address this within individual project files. I'd like to build the toolset on a build machine without having to run the sn.exe command on every build machine that may pull down our copy of WiX.
Many thanks Bob!