New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include the paths of linked wxi files to candle #5680

Open
mrbass21 opened this Issue Sep 11, 2017 · 1 comment

Comments

Projects
None yet
2 participants
@mrbass21

mrbass21 commented Sep 11, 2017

  • Describe the scenario and benefits that the feature supports.

When adding an include file to a WiX project (whether by link or by copying it to the main working folder), it's implicit that the directory where the include file lives should be included. I recently started using WiX because there was little knowledge of it at my company and the way our products are setup, there's many shared variables. I created a Common.wxi in a common folder outside of all the WiX projects. I added the Common,wxi file as link, and expected it to automatically be referenced by candle, since its path is in the wixproj file. Since I added the file, my tag did not include the path.

This feature request is really more about making it a little more "drop dead simple" for users. WiX has plenty of options for how to specify an included search location, but I think this feature re-enforces what the UI is displaying. An include file is added to the project, so you can just reference it without adding extra paths.

  • Describe how you're accomplishing the feature today (if possible).

I include the path to the folder containing the Common.wxi via the wixproj property sheet.

  • Describe what you'd like the new feature to do.

If a wixproj has a wxi file added to the project (as link or not), the path to that wxi file should automatically be added to the candle.exe arguments so the file can be referenced by name only in the tags.

@barnson barnson added this to the v4.x milestone Sep 14, 2017

@barnson

This comment has been minimized.

Show comment
Hide comment
@barnson

barnson Sep 14, 2017

Member

Nontrivial. Needs a WIP for Votive and MSBuild support.

Member

barnson commented Sep 14, 2017

Nontrivial. Needs a WIP for Votive and MSBuild support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment