New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Candle.exe should warn (instead of error) on duplicate preprocessor variables #5853

Closed
barnson opened this Issue Jul 24, 2018 · 1 comment

Comments

Projects
None yet
2 participants
@barnson
Copy link
Member

barnson commented Jul 24, 2018

Change request: Candle.exe currently emits an error if the same variable is specified more than one in -d switches, regardless of value. The preprocessor handles this case with warnings, regardless of value. Instead, both should be warnings if the values are the same.

  • Describe the scenario and benefits that the feature supports.

To be kind to the user who accidentally ended up with multiple DefineConstants in their .wixprojs.

  • Describe how you're accomplishing the feature today (if possible).

Being extremely precise about shared .wixproj authoring to avoid duplicates.

  • Describe what you'd like the new feature to do.

(See above.)

@barnson barnson self-assigned this Aug 2, 2018

@barnson barnson added this to the v4.0 milestone Aug 2, 2018

@snowmoonsoftware

This comment has been minimized.

Copy link

snowmoonsoftware commented Aug 31, 2018

Bump 👍 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment