New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nesting localized strings not working recursively #5860

Open
SokoFromNZ opened this Issue Aug 7, 2018 · 2 comments

Comments

Projects
None yet
3 participants
@SokoFromNZ
Copy link

SokoFromNZ commented Aug 7, 2018

Which version of WiX are you building with?
3.11.2318.0

Which version of Visual Studio are you building with (if any)?
15.7.6

Which version of the WiX Toolset Visual Studio Extension are you building with (if any)?
0.9.21.62588 (WiX Extension)

Which version of .NET are you building with?
4.5

Describe the problem and the steps to reproduce it.
I use an en-US.wxl file with the following content
<?xml version="1.0" encoding="utf-8"?> <WixLocalization Culture="en-US" Codepage="1252" xmlns="http://schemas.microsoft.com/wix/2006/localization"> <String Id="ApplicationVersion">4.03</String> <String Id="ApplicationNameWithVersion">MyAppName !(loc.ApplicationVersion)</String> <String Id="InstallationTypeLabel">Choose, if you want to run !(loc.ApplicationNameWithVersion) with a local database or on an administrated server database:</String> </WixLocalization>

As its not nicely readable after I commit this comment here's it again:
InstallationTypeLabel nests ApplicationNameWithVersion which nests ApplicationVersion

which gets used in InstallationTypeDialog.wxs:

<Control Id="InstallationTypeDescription" Type="Text" Text="!(loc.InstallationTypeLabel)" Height="20" Width="330" X="20" Y="60" />

When I run the setup it shows on the following wrong text on the dialog (bold added just here to see the difference):
"Choose, if you want to run MyAppName !(loc.ApplicationVersion) with a local database or on an administrated server database:"

Describe the behavior you expected and how it differed from the actual behavior.

When I run the setup it shows on the following text on the dialog (bold added just here to see the difference):
"Choose, if you want to run MyAppName 4.03 with a local database or on an administrated server database:"

I hope the bug is reproduceable for you
Thanks
Soko

@robmen

This comment has been minimized.

Copy link
Member

robmen commented Aug 7, 2018

Nested localization variables are not supported today. Triage could could consider it for WiX v4.

@SokoFromNZ

This comment has been minimized.

Copy link

SokoFromNZ commented Aug 7, 2018

Ok, I thought so...
Its just weird that 1-time nesting works.
Is this an undocumented feature ;)

@barnson barnson added this to the v4.0 milestone Aug 16, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment