New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WiX v4 throws odd error when using `==` operator #5880

Open
barnson opened this Issue Sep 26, 2018 · 1 comment

Comments

Projects
None yet
1 participant
@barnson
Copy link
Member

barnson commented Sep 26, 2018

  • Which version of WiX are you building with?

Core@ca2ed8db1e805ce815354cb0a29abb618a8d020a

  • Which version of Visual Studio are you building with (if any)?

n/a

  • Which version of the WiX Toolset Visual Studio Extension are you building with (if any)?

n/a

  • Which version of .NET are you building with?

4.7.2

  • If the problem occurs when installing your packages built with WiX, what is the version of Windows the package is running on?

n/a

  • Describe the problem and the steps to reproduce it.

An expression like

<?if $(sys.BUILDARCH) == "x64" ?>

yields the exception

WixToolset.Data.WixException : Found invalid subexpression '"x64"' in expression '$(sys.BUILDARCH) == "x64" '.
  • Describe the behavior you expected and how it differed from the actual behavior.

Well, first, let's address the fact that WiX uses = as its equality operator. I mean, really?! Fine, fine, whatever. If it can't support the One True Equality Operator, it should at least pinpoint the actually-invalid part of the expression, which isn't "x64".

@barnson barnson added this to the v4.0 milestone Oct 11, 2018

@barnson

This comment has been minimized.

Copy link
Member

barnson commented Oct 11, 2018

WiX v4 should accept both = and ==.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment