New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WiX v4: Malformed preprocessor instructions crashy #5881

Closed
barnson opened this Issue Sep 26, 2018 · 0 comments

Comments

Projects
None yet
1 participant
@barnson
Copy link
Member

barnson commented Sep 26, 2018

  • Which version of WiX are you building with?

Core@ca2ed8db1e805ce815354cb0a29abb618a8d020a

  • Which version of Visual Studio are you building with (if any)?

n/a

  • Which version of the WiX Toolset Visual Studio Extension are you building with (if any)?

n/a

  • Which version of .NET are you building with?

4.7.2

  • If the problem occurs when installing your packages built with WiX, what is the version of Windows the package is running on?

n/a

  • Describe the problem and the steps to reproduce it.

A ?if? without a matching ?endif? throws an uncaught exception:

WiX Toolset Core version 4.0.109.11978
Copyright (c) .NET Foundation and contributors. All rights reserved.

Unhandled Exception: WixToolset.Data.WixException: Found a <?if?> processing instruction without a matching <?endif?> after it.
   at WixToolset.Core.Preprocessor.PreprocessReader(Boolean include, XmlReader reader, XContainer container, Int32 offset)
   at WixToolset.Core.Preprocessor.Process(XmlReader reader)
   at WixToolset.Core.Preprocessor.Execute()
   at WixToolset.Core.CommandLine.BuildCommand.CompilePhase(IEnumerable`1 sourceFiles)
   at WixToolset.Core.CommandLine.BuildCommand.Execute()
   at WixToolset.Tools.Program.Run(IServiceProvider serviceProvider, IMessageListener listener, String[] args)
   at WixToolset.Tools.Program.Main(String[] args)
  • Describe the behavior you expected and how it differed from the actual behavior.

Internally using exceptions is great (I suppose) but they shouldn't escape. And the source-line-number info should be reported.

barnson added a commit to wixtoolset/Core that referenced this issue Sep 28, 2018

barnson added a commit to wixtoolset/Core that referenced this issue Sep 28, 2018

@barnson barnson added this to the v4.0 milestone Oct 11, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment