New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VS 2019 Support #5915

Open
chrpai opened this Issue Dec 5, 2018 · 5 comments

Comments

Projects
None yet
3 participants
@chrpai
Copy link

chrpai commented Dec 5, 2018

VS2019 Preview 1 was released on yesterday on 12/4. We need a WiX VS / Votive prototype extension for it to see where we stand.

I will try to generate one but I haven't even looked at the repos yet.

@barnson barnson modified the milestones: v4.0, v4.x Dec 6, 2018

@chrpai

This comment has been minimized.

Copy link

chrpai commented Dec 16, 2018

I have a solution for this. I simply cloned the VS2017 project to the VS2019 project and changed updated all version number references. I was able to build a VSIX that installed and worked just fine.

One note... VS2019 has a new File | New | Project UI and while I'm able to search for "wix" to find the project templates I can't locate it using the drop down filters. I'd say this is more of an additional feature enhancement though and this UI is only shown when doing a brand new project and you don't have a .sln yet. When you are adding a new project to an existing solution from the solution explorer, the legacy project type tree dialog is continued to be used as of preview 1.

image

image

@chrpai

This comment has been minimized.

Copy link

chrpai commented Dec 16, 2018

I can work on this.

@chrpai

This comment has been minimized.

Copy link

chrpai commented Dec 16, 2018

@barnson barnson modified the milestones: v4.x, v4.0 Jan 3, 2019

@vbaderks

This comment has been minimized.

Copy link

vbaderks commented Jan 4, 2019

Would it be possible to also apply this enhancement to v3.14?

@chrpai

This comment has been minimized.

Copy link

chrpai commented Jan 4, 2019

@vbaderks Votive is it's own repos that releases independent of WiX proper. This fix will work for both v3.11 and v3.14 when released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment