Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visual Studio 2022 integration? #6493

Closed
nbelyh opened this issue Jun 27, 2021 · 63 comments · Fixed by wixtoolset/VisualStudioExtension#22
Closed

Visual Studio 2022 integration? #6493

nbelyh opened this issue Jun 27, 2021 · 63 comments · Fixed by wixtoolset/VisualStudioExtension#22
Labels
Milestone

Comments

@nbelyh
Copy link

nbelyh commented Jun 27, 2021

Visual Studio 2022 integration does not seem to be available (yet?)
Would be nice to have it by the time 2022 is released.

Since it's x64, probably, there may be some issues.

Or maybe I am missing something?

@nbelyh nbelyh added the triage label Jun 27, 2021
@BMurri
Copy link

BMurri commented Jun 27, 2021

The WiX Toolset team has traditionally tried to time its releases to be near the public production release of the associated tool (so, usually not previews).

@ChrisShawK2
Copy link

Understood.
If a 'preview' version could be available earlier, though (even if only to let me load -- not run -- WiX projects), I'd install it right away, and then the real one when available...?

@barnson barnson added votive and removed triage labels Jul 8, 2021
@barnson barnson added this to the v4.0 milestone Jul 8, 2021
@rkieslinger
Copy link

Will Visual Studio 2022 integration support wix v3.xx?

@igalfsg
Copy link

igalfsg commented Oct 13, 2021

is there a beta or something we can try for VS 2022 RC?

@robmen
Copy link
Member

robmen commented Oct 13, 2021

Not yet. It is not common for us to push to get Votive released ahead of VS RTM. But this PR is promising.

@drolevar
Copy link

drolevar commented Oct 13, 2021

@robmen Do you have an idea whether wix3 will be patched to support VS2022? If you can think of releasing an updated version of wix3, I can do this.

@robmen
Copy link
Member

robmen commented Oct 13, 2021

@drolevar here's how we are operating right now:

  1. wix4 - this gets the attention. Things that distract us from this are secondary because we need to get wix4 done and released.
  2. WiX v3.14 changes - if someone does the work to contribute a fix to wix4 and makes a very good case why the change should be in WiX v3.14 and asks really kindly to accept the change into WiX v3.14, then we've been taking changes. This is a softening of our original position of WiX v3.14 where we said "only security fixes because we need to focus on wix4". Unfortunately, reality is wix4 is taking longer than hoped. But again, distracting from wix4 slows wix4 and I want to get wix4 done (see the pattern 😝 ).

@robmen
Copy link
Member

robmen commented Oct 13, 2021

Blair's comment about us usually working to RTM not pre-releases is correct).

Bookkeeping: there are two PRs for me to reconcile and test against VS2022:

  1. Add support for VS2022 VisualStudioExtension#19
  2. Add support for VS2022 VisualStudioExtension#21

@frozenprakash
Copy link

frozenprakash commented Oct 28, 2021

Any news on when any version of Wix Toolkit gonna come out for VS2022 support?
Wix Toolkit is the only thing stopping me from upgrading my solution from VS2019 to VS2022 😞

Also,
VS2022 RC3 itself is there now and VS2022 full version will be out by 2021-11-08 globally,
So will there be any version from Wix Toolkit which will be out for VS2022 support before 2021-11-08? ⌛

@robmen
Copy link
Member

robmen commented Oct 28, 2021

It is not common for us to push to get Votive released ahead of VS RTM.

@drolevar
Copy link

@frozenprakash If you are in real hurry (like me :) ) you can build it from the source as mentioned here wixtoolset/VisualStudioExtension#21.

@Terricide
Copy link

Anywhere to grab this without having to build source code myself?

@robmen
Copy link
Member

robmen commented Oct 28, 2021

Try https://bit.ly/2ZEW5Bt

@rseanhall rseanhall modified the milestones: v4.0, v.Votive Oct 31, 2021
@sfullerbeckman
Copy link

When is the Visual Studio 2022 Wix extension going to be released? Visual Studio 2022 was released today.

@robmen
Copy link
Member

robmen commented Nov 8, 2021

@sfullerbeckman Soon.

@drolevar
Copy link

drolevar commented Nov 8, 2021

@sfullerbeckman The Visual Studio SDK Nuget package is still in a preview state. So I'll wait until they issue a release version and then update this PR.

@danlyons-softek
Copy link

@drolevar Amusingly, it looks like the Visual Studio SDK Nuget package added a release version not long after your comment.

@FG-rgb
Copy link

FG-rgb commented Nov 9, 2021

When does there will be a release for the VS2022 Wix extension?

@robmen
Copy link
Member

robmen commented Nov 9, 2021

Soon

@frozenprakash
Copy link

Started a branch to test with Visual studio installer.

Not to discredit the Wix team, but in future this will be holding back my projects for several months before every future Visual studio releases.

@drolevar
Copy link

drolevar commented Nov 9, 2021

@frozenprakash Not to discredit you, but to you really plan on moving from WiX to .vdproj-based Visual Studio Installer? Or did I misunderstand you?

@mortenn
Copy link

mortenn commented Nov 9, 2021

@frozenprakash, in my opinion, if being able to use preview releases of VS is so important to you, then you should definitely use visual studio installer rather than wix toolset anyway.

While I personally do wish wix toolset would have worked in the 2022 preview so I could have used it for all the solutions I work on, it doesn't seem that critical to me.

@frozenprakash
Copy link

@frozenprakash, in my opinion, if being able to use preview releases of VS is so important to you, then you should definitely use visual studio installer rather than wix toolset anyway.

True that. I should had had an alternative installer to use during these needed situations.

@barnson
Copy link
Member

barnson commented Nov 13, 2021

@StevenRasmussen, actually I wanted to delay the release for at least 24 hours for every time someone asks, but Rob said that was mean.

@robmen
Copy link
Member

robmen commented Nov 13, 2021

Let me reiterate:

none of my customers have asked for Visual Studio 2022 support. If you are a customer, please do open a support ticket so we know to prioritize VS2022 work with the other things we are doing for all of our customers.
...
If the WiX Toolset is so important to you then become a customer or a contributor. Otherwise, as a user, wait while the contributors and customers carry the weight for you.

And:

Soon

@wixtoolset wixtoolset locked and limited conversation to collaborators Nov 13, 2021
@wixtoolset wixtoolset unlocked this conversation Nov 14, 2021
@robmen
Copy link
Member

robmen commented Nov 14, 2021

WiX Toolset Visual Studio Extensions v1.0.0.12 now includes support for Visual Studio 2022. Huge thanks to @drolevar for implementing the fix.

After we get validation from the community that v1.0.0.12 works in all versions of Visual Studio (2010-2022), we'll start the process to publish to Visual Studio Marketplace.

@robmen robmen closed this as completed Nov 14, 2021
@davidnmbond
Copy link

davidnmbond commented Nov 14, 2021

Visual Studio 2022 Community (Current) crashes and reloads for me when when building a simple wixproj on Windows 11 insider (latest).

I'm getting "Could not load file or assembly 'file:///C:\Program Files (x86)\WiX Toolset v3.11\bin\Heat.exe' or one of its dependencies. An attempt was made to load a program with an incorrect format."

The heat.exe file IS present at the location. A "repair" of the .exe installer v3.11.2 makes no difference.

Additional 1: installing v.3.14.0.5722 makes no difference - the message changes as expected to "Could not load file or assembly 'file:///C:\Program Files (x86)\WiX Toolset v3.14\bin\Heat.exe' or one of its dependencies. An attempt was made to load a program with an incorrect format." Again, the file is present. I'm trying to find some kind of log that tells me exactly what heat command was executed, so I can run it from the command line.

Additional 2: The command line is:
'C:\Program Files (x86)\WiX Toolset v3.14\bin\heat.exe' dir ..\My Project\bin\publish\ -cg WixInstallerAgent_Project -dr INSTALLFOLDER -scom -sreg -srd -var var.AgentHarvestPath -ag -sfrag -t HeatFilter.xsl -out WixInstallerAgent.wxs
This works fine at the command line. Bitness issue?

Additional 3: See @StevenBonePgh 's workaround, below.

@StevenBonePgh
Copy link

@davidnmbond Please see my comment at wixtoolset/VisualStudioExtension#21 (comment)
I have proposed some changes and give a workaround, and have not heard from any of the maintainers regarding the approach they would accept a PR for. Since writing the above, I saw some additional guidance in the .NET Blog MSBuild and 64-bit Visual Studio 2022 , where the wix.targets could be altered to specify Architecture="x86" for any MSBuild tasks that absolutely must be implemented as x86 only.

@davidnmbond
Copy link

davidnmbond commented Nov 14, 2021

@StevenBonePgh THANK YOU! A workaround, not a fix, but it did work.

For others suffering the same issue, here is what you should do until there is a fix:

  1. Right click on your Setup Project
  2. Unload Project
  3. Ctrl+F HeatDirectory
  4. Add an attribute: RunAsSeparateProcess="true"
  5. Ensure that any other HeatDirectory nodes are similarly updated
  6. Right click on your Setup Project
  7. Reload Project

@robmen
Copy link
Member

robmen commented Nov 14, 2021

A new issue is tracking that heat.exe problem here: #6636

@echalone
Copy link

WiX Toolset Visual Studio Extensions v1.0.0.12 now includes support for Visual Studio 2022. Huge thanks to @drolevar for implementing the fix.

After we get validation from the community that v1.0.0.12 works in all versions of Visual Studio (2010-2022), we'll start the process to publish to Visual Studio Marketplace.

It works for us, we're not using the HeatDirectory feature though. Thanks for the swift response and support of VS 2022! And sorry for any impatience on our "user" side ;)

drolevar pushed a commit to drolevar/VisualStudioExtension that referenced this issue Nov 30, 2021
@maniglia
Copy link

maniglia commented Dec 8, 2021

AppVeyor workaround:
Currently the Visual Studio 2022 image on AppVeyor does not contain the WixToolSet runtime and extension,
but you can download and install them before starting the build.
I report below an example for AppVeyor CI:

Script to download and install Wix: WixToolSet
Script to download and install extension: VS Extension

AppVeyor.yml example:
install:
- ps: .\install-wix.ps1 -PackageName "wix311.exe"
- ps: .\install-vsix.ps1 -PackageName "Votive2022.vsix"

In my case the extension works fine.

@barnson
Copy link
Member

barnson commented Dec 8, 2021

Votive 2022 is not needed in a CI image. And WiX support is coming: appveyor/ci#3754

@thompp
Copy link

thompp commented Dec 8, 2021

While testing with VS2022, am using wix to install a product that integrates with Visual Studio. It appears the properties to detect if VS2022 is installed are not yet implemented. I'm referring to the properties listed at https://wixtoolset.org/documentation/manual/v3/customactions/wixvsextension.html. Should that be logged as a separate issue?

@drolevar
Copy link

drolevar commented Dec 9, 2021

@thompp Here is the commit which adds VS2019 support: wixtoolset/wix3@3cc4b53
As you can see, it's implemented in the WiX extension for VS support, and not in the VS extension for WiX support. I know, that might look confusing.

@thompp
Copy link

thompp commented Dec 9, 2021

@drolevar does not look confusing at all. I think you are suggesting open this as a separate issue for VS2022 support in wix3 as maybe this issue is just around the integration via votive.

@demidov71
Copy link

I'm sorry to hit a nerve...
Ok, I want to support the project financially. How? Do you have a donation link?

maniglia added a commit to K-Society/KSociety.Log that referenced this issue Dec 17, 2021
@asm-flairstech
Copy link

Thank you

maniglia added a commit to K-Society/KSociety.Com that referenced this issue Dec 21, 2021
@robmen
Copy link
Member

robmen commented Dec 26, 2021

@demidov71 I think you are referring to your comment on the other VS2022 support issue. You did two things in that comment:

.NET 6 is available only on VS2022. Absence of WiX extension for it, hampers the development all over the world. Seriously, guys, leave the sofa!

First, you tried to guilt us into doing work for you. Second, you insulted us by suggesting we are lazy. You might consider apologizing to the people who actually work on the project instead of hinting that we shouldn't be offended by being insulted with:

I'm sorry to hit a nerve...

FireGiant provides commercial support for the WiX Toolset and provides guarantees on bug fixes (primarily targeted at corporate customers). You could go that route to become a customer instead of just a consumer.

We do not accept donations on the WiX project today because donations have not been shown to be a financially sufficient mechanism to fund software development.

@vivekvdj
Copy link

vivekvdj commented Apr 5, 2022

Hi Team,

May I know when the link (https://wixtoolset.org/documentation/manual/v3/customactions/wixvsextension.html) will be updated with VS2022 properties? We have one of the installers which is a plugin to Visual studio. and we need these properties to be updated in the installer Wix solution Please let us know the tentative date when it will be available?

Thanks.

@rseanhall
Copy link
Contributor

This issue was for WiX's own extension for Visual Studio. You are looking for #6727.

@vivekvdj
Copy link

vivekvdj commented Apr 12, 2022

This issue was for WiX's own extension for Visual Studio. You are looking for #6727.

Yes. I was looking for this issue. Thanks for guiding me to reach out to the correct page

@fartwhif
Copy link

installed WiX v3 - Visual Studio 2022 Extension
my WiX v3.11 setup project is incompatible with Visual Studio 2022

what gives?

@nbelyh
Copy link
Author

nbelyh commented Feb 16, 2023

@fartwhif you are doing something wrong. This issue was about supporting visual studio 2022, and it has been fixed long ago. In your place I would create a question on stackoverw under tag wix giving your problem details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.