New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIXBUG:4472 #110

Merged
merged 1 commit into from Jul 17, 2014

Conversation

Projects
None yet
3 participants
@rseanhall
Member

rseanhall commented Jul 15, 2014

Try to clean the downloaded update bundle from the cache.

@@ -1513,7 +1513,7 @@ extern "C" HRESULT PlanCleanPackage(
// The following are all different reasons why the package should be cleaned from the cache.
// The else-ifs are used to make the conditions easier to see (rather than have them combined
// in one huge condition).
if ((BURN_CACHE_TYPE_YES > pPackage->cacheType) && (BOOTSTRAPPER_ACTION_UPDATE_REPLACE != pPlan->action)) // easy, package is not supposed to stay cached.
if (BURN_CACHE_TYPE_YES > pPackage->cacheType) // easy, package is not supposed to stay cached.

This comment has been minimized.

@jchoover

jchoover Jul 15, 2014

Contributor

I'm ok with this as long as we do the second half of the change which is to add:

        // Prevent this package from being cleaned if we actually Plan an UpdateReplace.
        m_pEngineState->update.package.cacheType = BURN_CACHE_TYPE_YES;

inside of EngineForApplication.cpp, in SetUpdate after PseudoBundleInitialize.

@jchoover

jchoover Jul 15, 2014

Contributor

I'm ok with this as long as we do the second half of the change which is to add:

        // Prevent this package from being cleaned if we actually Plan an UpdateReplace.
        m_pEngineState->update.package.cacheType = BURN_CACHE_TYPE_YES;

inside of EngineForApplication.cpp, in SetUpdate after PseudoBundleInitialize.

This comment has been minimized.

@jchoover

jchoover Jul 16, 2014

Contributor

I stand corrected, we don't want to leave the package cached. This is the correct fix and my SetUpdate change is not needed..

@jchoover

jchoover Jul 16, 2014

Contributor

I stand corrected, we don't want to leave the package cached. This is the correct fix and my SetUpdate change is not needed..

barnson added a commit that referenced this pull request Jul 17, 2014

@barnson barnson merged commit 7746d55 into wixtoolset:develop Jul 17, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment