New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates wixba #121

Merged
merged 3 commits into from Jul 20, 2014

Conversation

Projects
None yet
3 participants
@jchoover
Contributor

jchoover commented Jul 20, 2014

Once the updates-core PR is accepted, and if we can get the WiX feed fixed, then these are the changes needed for the WixBA to use the engine based updates.

@jchoover

This comment has been minimized.

Show comment
Hide comment
@jchoover

jchoover Jul 20, 2014

Contributor

I've got something out of sync here. The call to DetectUpdateComplete no longer is getting the HR from DetectUpdate.

Contributor

jchoover commented Jul 20, 2014

I've got something out of sync here. The call to DetectUpdateComplete no longer is getting the HR from DetectUpdate.

@rseanhall

This comment has been minimized.

Show comment
Hide comment
@rseanhall

rseanhall Jul 20, 2014

Member

Looks good, besides a couple of style things (extra newline and "else if" not on its own line).

Member

rseanhall commented Jul 20, 2014

Looks good, besides a couple of style things (extra newline and "else if" not on its own line).

@barnson barnson merged commit 9d5e141 into wixtoolset:develop Jul 20, 2014

@barnson

This comment has been minimized.

Show comment
Hide comment
@barnson

barnson Jul 20, 2014

Member

I got the style things and added a log entry for incoming updates.

Member

barnson commented Jul 20, 2014

I got the style things and added a log entry for incoming updates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment