New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIXBUG:4486 #127

Merged
merged 2 commits into from Aug 1, 2014

Conversation

Projects
None yet
4 participants
@barnson
Member

barnson commented Jul 31, 2014

When writing to the Run/RunOnce key to handle in-chain reboots, include
the cached bundle stub.

WIXBUG:4486
When writing to the Run/RunOnce key to handle in-chain reboots, include
the cached bundle stub.

@barnson barnson added the bug label Jul 31, 2014

@rseanhall

This comment has been minimized.

Show comment
Hide comment
@rseanhall

rseanhall Jul 31, 2014

Member

The only thing that bothers is me that the deleted code had been there since v3.6. I can't help but wonder if there's other side effects, like the run once switch not being removed from the command line.

Member

rseanhall commented Jul 31, 2014

The only thing that bothers is me that the deleted code had been there since v3.6. I can't help but wonder if there's other side effects, like the run once switch not being removed from the command line.

@barnson

This comment has been minimized.

Show comment
Hide comment
@barnson

barnson Jul 31, 2014

Member

The idea is that the RunOnce key gets only " -burn.runonce" and the registration key gets all the command-line arguments. RegistrationGetResumeCommandLine pulls in the command-line arguments and re-launches the cached bundle (sans -burn.runonce).

Member

barnson commented Jul 31, 2014

The idea is that the RunOnce key gets only " -burn.runonce" and the registration key gets all the command-line arguments. RegistrationGetResumeCommandLine pulls in the command-line arguments and re-launches the cached bundle (sans -burn.runonce).

@rseanhall

This comment has been minimized.

Show comment
Hide comment
@rseanhall

rseanhall Aug 1, 2014

Member

Looks good.

Member

rseanhall commented Aug 1, 2014

Looks good.

@heaths

This comment has been minimized.

Show comment
Hide comment
@heaths

heaths Aug 1, 2014

Looks good. Not sure why it's different than what we have internally (which works). Perhaps sczCacheExecutablePath used to have the program and was changed? Either way, a better fix than backing it out (since it was an actual bug that RunOnce can only handle so many characters - though I forget the number off hand).

heaths commented on 680f0c0 Aug 1, 2014

Looks good. Not sure why it's different than what we have internally (which works). Perhaps sczCacheExecutablePath used to have the program and was changed? Either way, a better fix than backing it out (since it was an actual bug that RunOnce can only handle so many characters - though I forget the number off hand).

@robmen

This comment has been minimized.

Show comment
Hide comment
@robmen

robmen Aug 1, 2014

Member

@heaths We have a fix in Burn for installing drivers from WiX v3.8. Going to have to be careful about merging because the code bases are becoming more and more different (since you guys don't integrate back). :/

Member

robmen commented Aug 1, 2014

@heaths We have a fix in Burn for installing drivers from WiX v3.8. Going to have to be careful about merging because the code bases are becoming more and more different (since you guys don't integrate back). :/

robmen added a commit that referenced this pull request Aug 1, 2014

@robmen robmen merged commit 1aa9cbe into wixtoolset:develop Aug 1, 2014

@barnson barnson deleted the barnson:bug4486 branch May 8, 2015

@barnson barnson restored the barnson:bug4486 branch Feb 12, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment