New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #4206 - Firewall port list or range not possible #132

Merged
merged 2 commits into from Feb 14, 2015

Conversation

Projects
None yet
3 participants
@NorbertHD
Contributor

NorbertHD commented Aug 17, 2014

Change of (i)Port variable from integer to string is necessary to handle port ranges and lists. All the other port specific code already uses strings.

Issue #4206 - Firewall port list or range not possible
Change of (i)Port variable from integer to string is necessary to handle port ranges and lists. All the other port specific code already uses strings.
@robmen

This comment has been minimized.

Show comment
Hide comment
@robmen

robmen Jan 4, 2015

Member

Is there no validation we should be doing? Is any string valid?

Member

robmen commented Jan 4, 2015

Is there no validation we should be doing? Is any string valid?

@NorbertHD

This comment has been minimized.

Show comment
Hide comment
@NorbertHD

NorbertHD Jan 11, 2015

Contributor

Any number between 1 and 65535 is valid or any range by these numbers seperated by hyphen or any combination of these seperated by comma.
Is validation necessary? I have only seen this validation where only specific words are allowed.

E.g. registry extension doesn't check the parameters.
Also the current firewall port code doesn't check if the number is between 1 and 65535.

Contributor

NorbertHD commented Jan 11, 2015

Any number between 1 and 65535 is valid or any range by these numbers seperated by hyphen or any combination of these seperated by comma.
Is validation necessary? I have only seen this validation where only specific words are allowed.

E.g. registry extension doesn't check the parameters.
Also the current firewall port code doesn't check if the number is between 1 and 65535.

@@ -39,7 +39,7 @@ static UINT SchedFirewallExceptions(
LPWSTR pwzCustomActionData = NULL;
LPWSTR pwzName = NULL;
LPWSTR pwzRemoteAddresses = NULL;
int iPort = 0;
LPWSTR pwzPort = NULL;

This comment has been minimized.

@barnson

barnson Jan 30, 2015

Member

Needs a matching call to ReleaseStr at LExit.

Have you signed an assignment agreement? We'll need that. See http://wixtoolset.org/development/assignment-agreement/ for details.

@barnson

barnson Jan 30, 2015

Member

Needs a matching call to ReleaseStr at LExit.

Have you signed an assignment agreement? We'll need that. See http://wixtoolset.org/development/assignment-agreement/ for details.

This comment has been minimized.

@NorbertHD

NorbertHD Feb 1, 2015

Contributor

I have added the missing ReleaseStr and have signed the agreement on January 9. But I have not enough WiX programming knowledge/skills to program the parameter validation.

@NorbertHD

NorbertHD Feb 1, 2015

Contributor

I have added the missing ReleaseStr and have signed the agreement on January 9. But I have not enough WiX programming knowledge/skills to program the parameter validation.

barnson added a commit that referenced this pull request Feb 14, 2015

Merge pull request #132 from NorbertHD/develop
Issue #4206 - Firewall port list or range not possible

@barnson barnson merged commit d5faaac into wixtoolset:develop Feb 14, 2015

@barnson

This comment has been minimized.

Show comment
Hide comment
@barnson

barnson Feb 14, 2015

Member

Thanks!

Member

barnson commented Feb 14, 2015

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment