New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIXBUG:4501 - Add file size to upload metadata for use in releases feed. #135

Merged
merged 1 commit into from Aug 19, 2014

Conversation

Projects
None yet
2 participants
@robmen
Member

robmen commented Aug 18, 2014

No description provided.

//// { "name" : "data/wix36.msi", "contentType" : "application/octet-stream" },
//// { "name" : "data/wix36.cab", "contentType" : "application/octet-stream" },
//// { "name" : "wix36-binaries.zip", "contentType" : "application/octet-stream", "show" : true, "protected" : true }
//// { "name" : "wix36.exe", "contentType" : "application/octet-stream", "size" : 100, "show" : true },

This comment has been minimized.

@barnson

barnson Aug 19, 2014

Member

I assume @SiZe is always bytes? (I know 100's an example. :))

@barnson

barnson Aug 19, 2014

Member

I assume @SiZe is always bytes? (I know 100's an example. :))

This comment has been minimized.

@robmen

robmen Aug 19, 2014

Member

Yes. Not sure what unit it would be otherwise. :)


From: Bob Arnsonmailto:notifications@github.com
Sent: ý8/ý18/ý2014 19:02
To: wixtoolset/wix3mailto:wix3@noreply.github.com
Cc: Rob Menschingmailto:rob@robmensching.com
Subject: Re: [wix3] WIXBUG:4501 - Add file size to upload metadata for use in releases feed. (#135)

In tools/src/WixBuild/GenerateReleaseInfo.cs:

@@ -63,10 +63,10 @@ public override bool Execute()
//// "roots" : [ "~" ],
//// "files" :
//// [

  •        ////      { "name" : "wix36.exe", "contentType" : "application/octet-stream", "show" : true },
    
  •        ////      { "name" : "data/wix36.msi", "contentType" : "application/octet-stream"  },
    
  •        ////      { "name" : "data/wix36.cab", "contentType" : "application/octet-stream"  },
    
  •        ////      { "name" : "wix36-binaries.zip", "contentType" : "application/octet-stream", "show" : true, "protected" : true }
    
  •        ////      { "name" : "wix36.exe", "contentType" : "application/octet-stream", "size" : 100, "show" : true },
    

I assume @sizehttps://github.com/size is always bytes? (I know 100's an example. :))


Reply to this email directly or view it on GitHubhttps://github.com//pull/135/files#r16393649.

@robmen

robmen Aug 19, 2014

Member

Yes. Not sure what unit it would be otherwise. :)


From: Bob Arnsonmailto:notifications@github.com
Sent: ý8/ý18/ý2014 19:02
To: wixtoolset/wix3mailto:wix3@noreply.github.com
Cc: Rob Menschingmailto:rob@robmensching.com
Subject: Re: [wix3] WIXBUG:4501 - Add file size to upload metadata for use in releases feed. (#135)

In tools/src/WixBuild/GenerateReleaseInfo.cs:

@@ -63,10 +63,10 @@ public override bool Execute()
//// "roots" : [ "~" ],
//// "files" :
//// [

  •        ////      { "name" : "wix36.exe", "contentType" : "application/octet-stream", "show" : true },
    
  •        ////      { "name" : "data/wix36.msi", "contentType" : "application/octet-stream"  },
    
  •        ////      { "name" : "data/wix36.cab", "contentType" : "application/octet-stream"  },
    
  •        ////      { "name" : "wix36-binaries.zip", "contentType" : "application/octet-stream", "show" : true, "protected" : true }
    
  •        ////      { "name" : "wix36.exe", "contentType" : "application/octet-stream", "size" : 100, "show" : true },
    

I assume @sizehttps://github.com/size is always bytes? (I know 100's an example. :))


Reply to this email directly or view it on GitHubhttps://github.com//pull/135/files#r16393649.

barnson added a commit that referenced this pull request Aug 19, 2014

Merge pull request #135 from robmen/bug4501
WIXBUG:4501 - Add file size to upload metadata for use in releases feed.

@barnson barnson merged commit 2e35bde into wixtoolset:develop Aug 19, 2014

@robmen robmen deleted the robmen:bug4501 branch Jun 16, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment