New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIXBUG:4513 - Fix condition keyword detection in modularization regex. #148

Merged
merged 1 commit into from Oct 2, 2014

Conversation

Projects
None yet
2 participants
@robmen
Member

robmen commented Sep 14, 2014

The regex in the modularization of conditions would incorrectly recognize keywords that were part of property names. For example, the property "NOTEWORTHY" would be parsed as the keyword "NOT" and the property "EWORTHY". This fix ensures there is whitespace after keywords.

WIXBUG:4513 - Fix condition keyword detection in modularization regex.
The regex in the modularization of conditions would incorrectly
recognize keywords that were part of property names. For example, the
property "NOTEWORTHY" would be parsed as the keyword "NOT" and the
property "EWORTHY". This fix ensures there is whitespace after keywords.

@robmen robmen added this to the v3.10 milestone Sep 14, 2014

@robmen robmen removed the bug label Sep 14, 2014

@barnson barnson modified the milestones: v3.9, v3.10 Oct 2, 2014

barnson added a commit that referenced this pull request Oct 2, 2014

Merge pull request #148 from robmen/bug4513-modregex
 WIXBUG:4513 - Fix condition keyword detection in modularization regex.

@barnson barnson merged commit ead7f24 into wixtoolset:develop Oct 2, 2014

@robmen robmen deleted the robmen:bug4513-modregex branch Jun 16, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment