Allow Pyro to exclude empty patch transforms #156

Merged
merged 1 commit into from Nov 15, 2014

Projects

None yet

3 participants

@heaths
Contributor
heaths commented Sep 29, 2014

No description provided.

@barnson barnson merged commit 8e5ad86 into wixtoolset:develop Nov 15, 2014
@robmen
Member
robmen commented Nov 15, 2014

I thought we were doing this differently, or was "differently" only for wix4?


From: Bob Arnsonmailto:notifications@github.com
Sent: ý11/ý14/ý2014 18:55
To: wixtoolset/wix3mailto:wix3@noreply.github.com
Subject: Re: [wix3] Allow Pyro to exclude empty patch transforms (#156)

Merged #156#156.


Reply to this email directly or view it on GitHubhttps://github.com/wixtoolset/wix3/pull/156#event-193698864.

@barnson
Member
barnson commented Nov 15, 2014

Well, that was my recollection and now I doubt it...Clearly someone should have written it down because I don't remember what "differently" was. Grr.

@robmen
Member
robmen commented Nov 15, 2014

“Differently” was always allowing empty patch transforms but displaying a warning (that could be suppressed).

@heaths heaths deleted the heaths:issue4543 branch Nov 21, 2014
@barnson
Member
barnson commented Nov 27, 2014

@heaths Any objection? I can remove the switch.

@wixbot wixbot referenced this pull request in wixtoolset/issues Dec 20, 2015
Closed

Pyro does not allow "empty" transforms to be added #4543

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment