Add LaunchWorkingDir to wixstdba to facilitate processes that require a different working folder #159

Closed
wants to merge 3 commits into
from

Projects

None yet

3 participants

@BMurri
Contributor
BMurri commented Oct 7, 2014

WIXBUG:3750
Separate pull request created for wix4

@barnson barnson commented on an outdated diff Nov 14, 2014
@@ -1,3 +1,5 @@
+* BMurri: WIXBUG:3750 - Add LaunchWorkingDir to wixstdba to facilitate processes that require a different working folder.
@barnson
barnson Nov 14, 2014 Member

Dir should either be spelled out or changed to Folder. I think I prefer Folder a tiny bit but your call.

@BMurri
Contributor
BMurri commented Nov 17, 2014

Good idea. Updated both pull requests.

@barnson barnson and 2 others commented on an outdated diff Nov 27, 2014
src/ext/BalExtension/wixext/Xsd/bal.xsd
@@ -94,6 +94,15 @@
</xs:documentation>
</xs:annotation>
</xs:attribute>
+ <xs:attribute name="LaunchWorkingFolder" type="xs:string">
+ <xs:annotation>
+ <xs:documentation>
+ When used without the LaunchTargetElevatedId attribute, WixStdBA will use this working folder when launching the specified application.
@barnson
barnson Nov 27, 2014 Member

It appears to work for only non-elevated launch targets...?

@rseanhall
rseanhall Nov 27, 2014 Member

It's true, I didn't give any way in LaunchApprovedExe to specify the working folder. On the plus side, LaunchApprovedExe already sets the working folder to the exe's folder.

@BMurri
BMurri Nov 27, 2014 Contributor

Because the launch code uses ShellExec if the target is manifested the user will receive a prompt, so that will still work. ApprovedExes (which this bug did not mention) doesn't provide a means of specifying the working folder (as Sean mentioned) so it didn't make sense to allow this to be authored if it wouldn't be able to do anything. We would have to add an "Ex" method to the engine interface if we wanted to enable that.

Remember, this is WixStdBA code, not engine code available to all BAs.

@barnson
barnson Nov 27, 2014 Member

My point was that the doc describes what this attribute doesn't do, not what it does do. Something like

WixStdBA will use this working folder when launching the application specified by the LaunchTarget attribute. (Specifying a working folder for LaunchTargetElevatedId is not supported.)

If that's what happens.

@BMurri
BMurri Nov 28, 2014 Contributor

Got it!

I'll push an updated verbiage as soon as I get back to the machine it's on.

Sent from my Windows Phone


From: Bob Arnsonmailto:notifications@github.com
Sent: ‎11/‎27/‎2014 3:31 PM
To: wixtoolset/wix3mailto:wix3@noreply.github.com
Cc: BMurrimailto:blairlmurri@msn.com
Subject: Re: [wix3] Add LaunchWorkingDir to wixstdba to facilitate processes that require a different working folder (#159)

@@ -94,6 +94,15 @@
/xs:documentation
/xs:annotation
/xs:attribute

  •        <xs:attribute name="LaunchWorkingFolder" type="xs:string">
    
  •            xs:annotation
    
  •                xs:documentation
    
  •                    When used without the LaunchTargetElevatedId attribute, WixStdBA will use this working folder when launching the specified application.
    

My point was that the doc describes what this attribute doesn't do, not what it does do. Something like

WixStdBA will use this working folder when launching the application specified by the LaunchTarget attribute. (Specifying a working folder for LaunchTargetElevatedId is not supported.)

If that's what happens.


Reply to this email directly or view it on GitHub:
https://github.com/wixtoolset/wix3/pull/159/files#r21013297

@BMurri
Contributor
BMurri commented Dec 5, 2014

Bob, I've updated the help text in both wix3 and wix4.

@barnson
Member
barnson commented Dec 5, 2014

I squashed the pull and it lost the connection. Git, my dear friend...

@barnson barnson closed this Dec 5, 2014
@BMurri BMurri deleted the BMurri:issue3750 branch Jun 9, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment