New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WixBroadcastSettingChange #200

Merged
merged 3 commits into from Mar 15, 2015

Conversation

Projects
None yet
3 participants
@barnson
Member

barnson commented Feb 4, 2015

Add WixBroadcastSettingChange and WixBroadcastEnvironmentChange custom
actions to WixUtilExtension.

barnson added some commits Feb 4, 2015

WixBroadcastSettingChange
Add WixBroadcastSettingChange and WixBroadcastEnvironmentChange custom
actions to WixUtilExtension.
<CustomActionRef Id="WixBroadcastSettingChange" />
<CustomActionRef Id="WixBroadcastEnvironmentChange" />
This will cause WiX to add the custom action to your MSI and schedule it immediately after the <a href="http://msdn.microsoft.com/library/aa369505.aspx" target="_blank">InstallFinalize</a> standard action.

This comment has been minimized.

@heaths

heaths Mar 6, 2015

Contributor

Does the link render correctly? Not typical for markdown files.

@heaths

heaths Mar 6, 2015

Contributor

Does the link render correctly? Not typical for markdown files.

This comment has been minimized.

@barnson

barnson Mar 9, 2015

Member

Of course. Markdown doesn't support opening links in new windows.

@barnson

barnson Mar 9, 2015

Member

Of course. Markdown doesn't support opening links in new windows.

ExitOnFailure(hr, "failed to initialize WixBroadcastSettingChange");
// best effort; ignore failures
::SendMessageTimeoutW(HWND_BROADCAST, WM_SETTINGCHANGE, NULL, NULL, SMTO_ABORTIFHUNG, 1000, NULL);

This comment has been minimized.

@heaths

heaths Mar 6, 2015

Contributor

Why not PostMessage for async broadcasting? Also, since this is immediate it is subject to integrity levels. Maybe this should be scheduled last before InstallFinalize as a commit CA so it's elevated.

@heaths

heaths Mar 6, 2015

Contributor

Why not PostMessage for async broadcasting? Also, since this is immediate it is subject to integrity levels. Maybe this should be scheduled last before InstallFinalize as a commit CA so it's elevated.

This comment has been minimized.

@robmen

robmen Mar 15, 2015

Member

Documentation for WM_SETTINGCHANGE says use ::SendMessageTimeout(). Seems reasonable given available information.

@robmen

robmen Mar 15, 2015

Member

Documentation for WM_SETTINGCHANGE says use ::SendMessageTimeout(). Seems reasonable given available information.

@robmen robmen merged commit 5c7ee3d into wixtoolset:develop Mar 15, 2015

robmen added a commit that referenced this pull request Mar 15, 2015

@barnson barnson deleted the barnson:BroadcastSettingChange.1 branch Mar 15, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment