Add WixStdBaLanguage language and documentation. #219

Merged
merged 3 commits into from Mar 15, 2015

Projects

None yet

4 participants

@barnson
Member
barnson commented Mar 6, 2015

No description provided.

@heaths
Contributor
heaths commented Mar 6, 2015

Looks good.

@rseanhall rseanhall and 2 others commented on an outdated diff Mar 7, 2015
...nsion/wixstdba/WixStandardBootstrapperApplication.cpp
static const LPCWSTR WIXSTDBA_VARIABLE_BUNDLE_FILE_VERSION = L"WixBundleFileVersion";
+static const LPCWSTR WIXSTDBA_VARIABLE_LANGUAGE = L"WixStdBaLanguage";
@rseanhall
rseanhall Mar 7, 2015 Member

Looks good, just have some naming comments. In my wix4 pull request, I created some variables that all started with WixStdBA (capital A). I'm neutral on which one's better.

There's already SystemLanguageID and UserLanguageID Burn variables. This one should probably end in ID, too.

@rseanhall
rseanhall Mar 9, 2015 Member

Awesome, I don't have to update my pull request :)

@robmen
robmen Mar 10, 2015 Member

Except "Id" is expected instead of "ID". From the same MSDN article:

Note

The two abbreviations that can be used in identifiers are ID and OK. In Pascal-cased identifiers they should appear as Id, and Ok. If used as the first word in a camel-cased identifier, they should appear as id and ok, respectively.

@robmen robmen merged commit f3d714b into wixtoolset:develop Mar 15, 2015
@barnson barnson deleted the barnson:WixStdBaLanguage.0 branch Mar 15, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment