New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIXFEAT:3933 - Make WixBundleManufacturer variable writable #226

Merged
merged 2 commits into from Apr 13, 2015

Conversation

Projects
None yet
3 participants
@rseanhall
Member

rseanhall commented Mar 29, 2015

No description provided.

ExitOnFailure1(hr, "Failed to write %ls value.", REGISTRY_BUNDLE_PUBLISHER);
}
hr = GetBundleManufacturer(pRegistration, pVariables, &sczPublisher);
hr = RegWriteString(hkRegistration, REGISTRY_BUNDLE_PUBLISHER, SUCCEEDED(hr) ? sczPublisher : pRegistration->sczPublisher);

This comment has been minimized.

@barnson

barnson Mar 30, 2015

Member

Any reason to skip normal ExitOnFailure handling? If GetBundleManufacturer, it's probably catastrophic anyway...

@barnson

barnson Mar 30, 2015

Member

Any reason to skip normal ExitOnFailure handling? If GetBundleManufacturer, it's probably catastrophic anyway...

This comment has been minimized.

@rseanhall

rseanhall Mar 30, 2015

Member

Just handling it like GetBundleName above.

@rseanhall

rseanhall Mar 30, 2015

Member

Just handling it like GetBundleName above.

This comment has been minimized.

@barnson

barnson Mar 30, 2015

Member

If only I had post-commit telepathy to know why that was done that way...

@barnson

barnson Mar 30, 2015

Member

If only I had post-commit telepathy to know why that was done that way...

This comment has been minimized.

This comment has been minimized.

@robmen

robmen Apr 7, 2015

Member

Avoid non fatal error, I think.

@robmen

robmen Apr 7, 2015

Member

Avoid non fatal error, I think.

@barnson barnson merged commit 4a50738 into wixtoolset:develop Apr 13, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment