New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Silent Exec Custom Action #230

Merged
merged 8 commits into from Apr 13, 2015

Conversation

Projects
None yet
3 participants
@firegiantco

firegiantco commented Apr 9, 2015

QuietExec outputs both the command and the standard output to the log, which is problematic if you are passing in a password or similar. The new SilentExec custom action allows one to run an executable without outputting the command or the standard output of the program.

Also, provide a new, more consistent name for quiet exec functionality (WixQuietExec instead of CAQuietExec). It behaves no different than the old name, and the old name still works.

Mike Carlson and others added some commits Mar 19, 2015

Mike Carlson
Implement a new WixSilentExec custom action, which allows users to en…
…sure input and output of the executable are never logged, intended for security / privacy scenarios. Also create a new custom action which matches the behavior of CAQuietExec, but has a new name, WixQuietExec.

@firegiantco firegiantco changed the title from Silent exec pull to Create Silent Exec Custom Action Apr 9, 2015

Show outdated Hide outdated src/ext/ca/wixca/dll/qtexecca.cpp
hr = WcaGetProperty( L"QtExecCmdTimeout", &pwzData);
ExitOnFailure(hr, "failed to get QtExecCmdTimeout");
hr = WcaGetProperty(wzPropertyName, &pwzData);
ExitOnFailure1(hr, "failed to get %ls", wzPropertyName);

This comment has been minimized.

@heaths

heaths Apr 10, 2015

Contributor

Should use the variadic macros now (just drop the "1" in the macro - they will be removed eventually).

@heaths

heaths Apr 10, 2015

Contributor

Should use the variadic macros now (just drop the "1" in the macro - they will be removed eventually).

Show outdated Hide outdated src/ext/ca/wixca/dll/qtexecca.cpp
ExitOnFailure(hr, "failed to initialize");
hr = ExecCommon64(CAQUIET64_ARGUMENTS_PROPERTY, CAQUIET_TIMEOUT_PROPERTY, TRUE, TRUE);
ExitOnFailure(hr, "Failed in method");

This comment has been minimized.

@heaths

heaths Apr 10, 2015

Contributor

Missing method name.

@heaths

heaths Apr 10, 2015

Contributor

Missing method name.

Show outdated Hide outdated src/libs/wcautil/qtexec.cpp
else
{
hr = StrAllocStringAnsi(&szTemp, (LPCSTR)pBuffer, 0, CP_OEMCP);
ExitOnFailure(hr, "failed to allocate output string");

This comment has been minimized.

@heaths

heaths Apr 10, 2015

Contributor

Since you're fixing up the code, may as well capitalize "failed" as new code does.

@heaths

heaths Apr 10, 2015

Contributor

Since you're fixing up the code, may as well capitalize "failed" as new code does.

Mike Carlson added some commits Apr 10, 2015

@firegiantco

This comment has been minimized.

Show comment
Hide comment
@firegiantco

firegiantco Apr 10, 2015

Thanks for the comments, Heath. Commits were added to resolve them.

firegiantco commented Apr 10, 2015

Thanks for the comments, Heath. Commits were added to resolve them.

barnson added a commit that referenced this pull request Apr 13, 2015

Merge pull request #230 from firegiant/silent-exec-pull
Create Silent Exec Custom Action

@barnson barnson merged commit 1cae6e8 into wixtoolset:develop Apr 13, 2015

@Mike-GC Mike-GC deleted the firegiant:silent-exec-pull branch Jul 1, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment