New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIXBUG:4731 - Obscure hidden variable values in the logged command line #232

Merged
merged 1 commit into from Apr 13, 2015

Conversation

Projects
None yet
2 participants
@rseanhall
Member

rseanhall commented Apr 12, 2015

No description provided.

@barnson barnson merged commit 359c898 into wixtoolset:develop Apr 13, 2015

@barnson

This comment has been minimized.

Show comment
Hide comment
@barnson

barnson Apr 13, 2015

Member

Please check my merge for bad conflict resolution.

Member

barnson commented Apr 13, 2015

Please check my merge for bad conflict resolution.

hr = VariableInitialize(&pEngineState->variables);
ExitOnFailure(hr, "Failed to initialize variables.");
// retain whether burn was initially run elevated

This comment has been minimized.

@rseanhall

rseanhall Apr 14, 2015

Member

Your merge looks good, though I did purposely delete this comment since BURN_BUNDLE_ELEVATED is not there to "retain whether burn was initally run elevated".

@rseanhall

rseanhall Apr 14, 2015

Member

Your merge looks good, though I did purposely delete this comment since BURN_BUNDLE_ELEVATED is not there to "retain whether burn was initally run elevated".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment