New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIXBUG:4734 - Rewrote type-51 CAs using SetProperty. #235

Merged
merged 2 commits into from May 19, 2015

Conversation

Projects
None yet
2 participants
@barnson
Member

barnson commented Apr 16, 2015

No description provided.

Show outdated Hide outdated src/chm/documents/customactions/qtexec.html.md
<CustomAction Id="QtExecDeferredExampleWithProperty_Cmd" Property="QtExecDeferredExampleWithProperty"
Value="&quot;[#MyExecutable.exe]&quot;" Execute="immediate"/>
<SetProperty Id="QtExecDeferredExampleWithProperty" After="CostFinalize"

This comment has been minimized.

@robmen

robmen Apr 25, 2015

Member

I think a better option than CostFinalize here is to use the name of the CustomAction it is setting the data for. Also, remove the SetProperty/@Id.

@robmen

robmen Apr 25, 2015

Member

I think a better option than CostFinalize here is to use the name of the CustomAction it is setting the data for. Also, remove the SetProperty/@Id.

This comment has been minimized.

@barnson

barnson Apr 25, 2015

Member
  1. OK. 2. I think we need Id given that it's the id of the property and required. :)
@barnson

barnson Apr 25, 2015

Member
  1. OK. 2. I think we need Id given that it's the id of the property and required. :)

@robmen robmen merged commit d5fb88c into wixtoolset:develop May 19, 2015

robmen added a commit that referenced this pull request May 19, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment