New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIXBUG:4716 #243

Merged
merged 1 commit into from May 24, 2015

Conversation

Projects
None yet
3 participants
@barnson
Member

barnson commented May 4, 2015

If a .wxl file is missing strings added in v3.10, duplicate the generic string from v3.9. Add support for doing so to locutil.

Show outdated Hide outdated src/libs/dutil/locutil.cpp
pWixLoc->rgLocStrings = static_cast<LOC_STRING*>(MemReAlloc(pWixLoc->rgLocStrings, sizeof(LOC_STRING) * pWixLoc->cLocStrings, TRUE));
ExitOnNull(pWixLoc->rgLocStrings, hr, E_OUTOFMEMORY, "Failed to reallocate memory for localization strings.");
LOC_STRING* pLocString = pLocString = pWixLoc->rgLocStrings + (pWixLoc->cLocStrings - 1);

This comment has been minimized.

@rseanhall

rseanhall May 19, 2015

Member

pLocString = pLocString? Other than that, looks good.

@rseanhall

rseanhall May 19, 2015

Member

pLocString = pLocString? Other than that, looks good.

If a .wxl file is missing strings added in v3.10, duplicate the gener…
…ic string from v3.9. Add support for doing so to locutil.

@robmen robmen merged commit 1af2877 into wixtoolset:develop May 24, 2015

@barnson barnson deleted the barnson:bug4716 branch Sep 6, 2015

@barnson barnson restored the barnson:bug4716 branch Feb 12, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment