New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add VSIX property for VS2015 and fix older searches #247

Merged
merged 1 commit into from May 12, 2015

Conversation

Projects
None yet
2 participants
@heaths
Contributor

heaths commented May 10, 2015

The older VWD searches were looking in the wrong place (wasn't VWD-specific) and the CA conditions were checking the wrong property. Also reorganized the CAs to execution in release / edition succession decending for ease.

Add VSIX property for VS2015 and fix older searches
The older VWD searches were looking in the wrong place (wasn't VWD-specific) and the CA conditions were checking
the wrong property. Also reorganized the CAs to execution in release / edition succession decending for ease.
<SetProperty Action="Vwd2015VsixWhenVSAbsent" Id="VS_VSIX_INSTALLER_PATH" Value="[VWD2015_VSIX_INSTALL_ROOT]\Common7\IDE\VSIXInstaller.exe" Sequence="both" After="AppSearch">NOT VS_VSIX_INSTALLER_PATH AND VWD2015_VSIX_INSTALL_ROOT</SetProperty>
<SetProperty Action="SetVS2013Vsix" Id="VS_VSIX_INSTALLER_PATH" Value="[VS2013_VSIX_INSTALLER_PATH]" Sequence="both" After="Vwd2015VsixWhenVSAbsent">NOT VS_VSIX_INSTALLER_PATH AND VS2013_VSIX_INSTALLER_PATH</SetProperty>
<SetProperty Action="Vwd2013VsixWhenVSAbsent" Id="VS_VSIX_INSTALLER_PATH" Value="[VWD2013_VSIX_INSTALL_ROOT]\Common7\IDE\VSIXInstaller.exe" Sequence="both" After="SetVS2013Vsix">NOT VS_VSIX_INSTALLER_PATH AND VWD2013_VSIX_INSTALL_ROOT</SetProperty>

This comment has been minimized.

@barnson

barnson May 12, 2015

Member

This won't support simultaneous VWD and Pro+ installs (VWD wins). Do we care? (I see it's not a regression, just curious about whether we need to look at running multiple times.)

@barnson

barnson May 12, 2015

Member

This won't support simultaneous VWD and Pro+ installs (VWD wins). Do we care? (I see it's not a regression, just curious about whether we need to look at running multiple times.)

This comment has been minimized.

@heaths

heaths May 12, 2015

Contributor

Don't need to. VSIXInstaller.exe will install to whatever VS versions it find. I opted to work backward from newest to oldest, and for each release prefer Pro+ then VWD.

@heaths

heaths May 12, 2015

Contributor

Don't need to. VSIXInstaller.exe will install to whatever VS versions it find. I opted to work backward from newest to oldest, and for each release prefer Pro+ then VWD.

This comment has been minimized.

@barnson

barnson May 12, 2015

Member

Cool.

@barnson

barnson May 12, 2015

Member

Cool.

@barnson barnson merged commit 7667a8f into wixtoolset:develop May 12, 2015

@heaths heaths deleted the heaths:issue4757 branch May 12, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment