New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIXFEAT:4382 Added support for "files in use" to WixStdBA #250

Merged
merged 2 commits into from May 25, 2015

Conversation

Projects
None yet
3 participants
@creativbox
Contributor

creativbox commented May 17, 2015

No description provided.

@barnson

This comment has been minimized.

Show comment
Hide comment
@barnson

barnson May 17, 2015

Member

Thanks, this is great! Small issue: because it's a behavior change and introduces new loc strings, it needs to be opt-in for WiX v3.x. WixStdBA has a bunch of flags like that; see, for example, https://github.com/wixtoolset/wix3/blob/develop/src/ext/BalExtension/wixext/BalCompiler.cs#L303. Can you add ShowFilesInUse?

Member

barnson commented May 17, 2015

Thanks, this is great! Small issue: because it's a behavior change and introduces new loc strings, it needs to be opt-in for WiX v3.x. WixStdBA has a bunch of flags like that; see, for example, https://github.com/wixtoolset/wix3/blob/develop/src/ext/BalExtension/wixext/BalCompiler.cs#L303. Can you add ShowFilesInUse?

@creativbox

This comment has been minimized.

Show comment
Hide comment
@creativbox

creativbox May 17, 2015

Contributor

I'm still fighting with GIT, but I think I got it right. I've added a "ShowFilesInUse" option the same way as mentioned by you. Please check it out.

Contributor

creativbox commented May 17, 2015

I'm still fighting with GIT, but I think I got it right. I've added a "ShowFilesInUse" option the same way as mentioned by you. Please check it out.

if (pPackage && BAL_INFO_PACKAGE_TYPE_MSI == pPackage->type)
{
return ShowFilesInUseModal(cFiles, rgwzFiles);

This comment has been minimized.

@rseanhall

rseanhall May 19, 2015

Member

Calling it modal is really confusing to me when it's just another page. I'd really like to see the new page be a modal window instead.

@rseanhall

rseanhall May 19, 2015

Member

Calling it modal is really confusing to me when it's just another page. I'd really like to see the new page be a modal window instead.

This comment has been minimized.

@creativbox

creativbox May 19, 2015

Contributor

It is similar to a modal dialog regarding the other pages and the concept was inspired by dialogs too. That’s where the name was coming from. What would be a better name?

@creativbox

creativbox May 19, 2015

Contributor

It is similar to a modal dialog regarding the other pages and the concept was inspired by dialogs too. That’s where the name was coming from. What would be a better name?

@barnson barnson merged commit a708009 into wixtoolset:develop May 25, 2015

@barnson

This comment has been minimized.

Show comment
Hide comment
@barnson

barnson May 25, 2015

Member

I did a bit of style cleanup and added a history entry. It would be great if ThmUtil understood modal pages/dialogs but this is fine, especially in v3.x.

Member

barnson commented May 25, 2015

I did a bit of style cleanup and added a history entry. It would be great if ThmUtil understood modal pages/dialogs but this is fine, especially in v3.x.

@creativbox

This comment has been minimized.

Show comment
Hide comment
@creativbox

creativbox May 25, 2015

Contributor

Thanks a lot!

Contributor

creativbox commented May 25, 2015

Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment