New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIXFEAT:4781 - Do a best-effort duplication of strings instead of fai… #260

Merged
merged 1 commit into from Jun 9, 2015

Conversation

Projects
None yet
3 participants
@barnson
Copy link
Member

barnson commented May 31, 2015

…ling if there's a missing string.

// Duplicate strings, best-effort only.
if (SUCCEEDED(LocGetString(m_pWixLoc, L"#(loc.SuccessHeader)", &pLocString)))
{
hr = LocAddString(m_pWixLoc, L"SuccessInstallHeader", pLocString->wzText, pLocString->bOverridable);

This comment has been minimized.

@rseanhall

rseanhall Jun 2, 2015

Member

What happens when you add a string that already exists?

This comment has been minimized.

@barnson

barnson Jun 8, 2015

Member

It succeeds, though it's essentially hidden. (The original is found first.) So the only failure here is OOM and other about-to-blow-up-anyway errors.

robmen added a commit that referenced this pull request Jun 9, 2015

Merge pull request #260 from barnson/bug4781
WIXFEAT:4781 - Do a best-effort duplication of strings instead of fai…

@robmen robmen merged commit 9b37d4d into wixtoolset:develop Jun 9, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment