WiX BA allows multiple clicks of Install button while update check is running #262

Merged
merged 2 commits into from Jun 10, 2015

Projects

None yet

4 participants

@heaths
Contributor
heaths commented Jun 8, 2015

Looks okay, but wouldn't just disabling the Install button suffice until DetectComplete? That's basically what we do in our BA.

@jchoover
Contributor
jchoover commented Jun 8, 2015

Heath,
Can't do that cleanly cause we are dog fooding the engine feed updating. In 3.x I couldn't modify signatures, so we have to call detect a second time if the update feed fails. I suppose we could make it conditional based off of if Detect succeeded, but it seemed more logical to break this into two different states.

@robmen robmen and 1 other commented on an outdated diff Jun 9, 2015
src/Setup/WixBA/RootViewModel.cs
}
set
{
- if (this.state != value)
+ if (this.detectstate != value)
@robmen
robmen Jun 9, 2015 Member

Should be detectState? Two words?

@jchoover
jchoover Jun 10, 2015 Contributor

Fixed in updated PR

@robmen robmen and 1 other commented on an outdated diff Jun 9, 2015
src/Setup/WixBA/RootViewModel.cs
// Notify all the properties derived from the state that the state changed.
- base.OnPropertyChanged("State");
+ base.OnPropertyChanged("DetectState");
+ base.OnPropertyChanged("CancelEnabled");
+ }
+ }
+ }
+
+ /// <summary>
+ /// Gets and sets the installation state of the view's model.
+ /// </summary>
+ public InstallationState InstallState
+ {
+ get
+ {
+ return this.installstate;
@robmen
robmen Jun 9, 2015 Member

Ditto but installState.

@jchoover
jchoover Jun 10, 2015 Contributor

Fixed in updated PR

@jchoover jchoover WIXBUG:4512 - WiX BA allows multiple clicks of Install button while u…
…pdate check is running

- Added history entry
- Fixed variable casing
e691b7f
@barnson barnson commented on the diff Jun 10, 2015
History.md
@@ -1,3 +1,5 @@
+* JacobHoover: WIXBUG:4512 - fix WiX BA, prevent multiple install clicks
+
@barnson
barnson Jun 10, 2015 Member

Remember the new history scheme...

@barnson barnson merged commit e691b7f into wixtoolset:develop Jun 10, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment