New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WiX BA allows multiple clicks of Install button while update check is running #262

Merged
merged 2 commits into from Jun 10, 2015

Conversation

Projects
None yet
4 participants
@heaths

This comment has been minimized.

Show comment
Hide comment
@heaths

heaths Jun 8, 2015

Contributor

Looks okay, but wouldn't just disabling the Install button suffice until DetectComplete? That's basically what we do in our BA.

Contributor

heaths commented Jun 8, 2015

Looks okay, but wouldn't just disabling the Install button suffice until DetectComplete? That's basically what we do in our BA.

@jchoover

This comment has been minimized.

Show comment
Hide comment
@jchoover

jchoover Jun 8, 2015

Contributor

Heath,
Can't do that cleanly cause we are dog fooding the engine feed updating. In 3.x I couldn't modify signatures, so we have to call detect a second time if the update feed fails. I suppose we could make it conditional based off of if Detect succeeded, but it seemed more logical to break this into two different states.

Contributor

jchoover commented Jun 8, 2015

Heath,
Can't do that cleanly cause we are dog fooding the engine feed updating. In 3.x I couldn't modify signatures, so we have to call detect a second time if the update feed fails. I suppose we could make it conditional based off of if Detect succeeded, but it seemed more logical to break this into two different states.

Show outdated Hide outdated src/Setup/WixBA/RootViewModel.cs
}
set
{
if (this.state != value)
if (this.detectstate != value)

This comment has been minimized.

@robmen

robmen Jun 9, 2015

Member

Should be detectState? Two words?

@robmen

robmen Jun 9, 2015

Member

Should be detectState? Two words?

This comment has been minimized.

@jchoover

jchoover Jun 10, 2015

Contributor

Fixed in updated PR

@jchoover

jchoover Jun 10, 2015

Contributor

Fixed in updated PR

Show outdated Hide outdated src/Setup/WixBA/RootViewModel.cs
{
get
{
return this.installstate;

This comment has been minimized.

@robmen

robmen Jun 9, 2015

Member

Ditto but installState.

@robmen

robmen Jun 9, 2015

Member

Ditto but installState.

This comment has been minimized.

@jchoover

jchoover Jun 10, 2015

Contributor

Fixed in updated PR

@jchoover

jchoover Jun 10, 2015

Contributor

Fixed in updated PR

WIXBUG:4512 - WiX BA allows multiple clicks of Install button while u…
…pdate check is running

- Added history entry
- Fixed variable casing
@@ -1,3 +1,5 @@
* JacobHoover: WIXBUG:4512 - fix WiX BA, prevent multiple install clicks

This comment has been minimized.

@barnson

barnson Jun 10, 2015

Member

Remember the new history scheme...

@barnson

barnson Jun 10, 2015

Member

Remember the new history scheme...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment