New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug #4792 #268

Merged
merged 3 commits into from Jun 16, 2015

Conversation

Projects
None yet
4 participants
@stunney
Contributor

stunney commented Jun 10, 2015

Adding validation of WixPdb to paired MSI to ensure that the two
actually belong together.

Bug #4792
Adding validation of WixPdb to paired MSI to ensure that the two
actually belong together.
@robmen

This comment has been minimized.

Show comment
Hide comment
@robmen

robmen Jun 11, 2015

Member

Two very big things:

  1. Only check the PackageCode. That will be an exact match.
  2. Don't send messages by throwing exceptions. Write a message like all the other code.
Member

robmen commented Jun 11, 2015

Two very big things:

  1. Only check the PackageCode. That will be an exact match.
  2. Don't send messages by throwing exceptions. Write a message like all the other code.
@stunney

This comment has been minimized.

Show comment
Hide comment
@stunney

stunney Jun 11, 2015

Contributor
  1. Agreed
  2. Crap, my bad.
Contributor

stunney commented Jun 11, 2015

  1. Agreed
  2. Crap, my bad.
@stunney

This comment has been minimized.

Show comment
Hide comment
@stunney

stunney Jun 11, 2015

Contributor

Would you recommend that melt still "abort" upon discovering the mismatch or simply serve up a "WARNING" on the console?

Contributor

stunney commented Jun 11, 2015

Would you recommend that melt still "abort" upon discovering the mismatch or simply serve up a "WARNING" on the console?

@robmen

This comment has been minimized.

Show comment
Hide comment
@robmen

robmen Jun 12, 2015

Member

For WiX v3.x I think it has to be a warning since maybe someone is doing this and it is working for them (magically). It should become an error in v4.x.

Member

robmen commented Jun 12, 2015

For WiX v3.x I think it has to be a warning since maybe someone is doing this and it is working for them (magically). It should become an error in v4.x.

@stunney

This comment has been minimized.

Show comment
Hide comment
@stunney

stunney Jun 12, 2015

Contributor

Already added the warning string to the resource file.

Contributor

stunney commented Jun 12, 2015

Already added the warning string to the resource file.

@stunney

This comment has been minimized.

Show comment
Hide comment
@stunney

stunney Jun 12, 2015

Contributor

New PR will be up tonight.

Contributor

stunney commented Jun 12, 2015

New PR will be up tonight.

@robmen

This comment has been minimized.

Show comment
Hide comment
@robmen

robmen Jun 12, 2015

Member

You don't need a new PR, you can just update your branch and push back to it. That will update this pull request.

Member

robmen commented Jun 12, 2015

You don't need a new PR, you can just update your branch and push back to it. That will update this pull request.

Bug #4792 - feedback updates
Based on feedback from Rob here:
#268
Using proper resource string for messages + Console instead of
exceptions.
Only checking ProductCode since it is the one true definition of a
unique MSI creation
@stunney

This comment has been minimized.

Show comment
Hide comment
@stunney

stunney Jun 12, 2015

Contributor

updates committed

Contributor

stunney commented Jun 12, 2015

updates committed

@heaths

View changes

Show outdated Hide outdated src/tools/melt/melt.cs
Bug #4792 - continued feedback updates
More feedback from Heath.  Moved KEY_PRODUCT_CODE out as static readonly
in class definition.  Added a break statement to get out of the for loop
as soon as we have looks at the "ProductCode" row.  Added missing method
comments.
@stunney

This comment has been minimized.

Show comment
Hide comment
@stunney

stunney Jun 13, 2015

Contributor

Updates based on @heaths feedback committed.

Contributor

stunney commented Jun 13, 2015

Updates based on @heaths feedback committed.

@barnson barnson merged commit aa540d1 into wixtoolset:develop Jun 16, 2015

rseanhall added a commit to rseanhall/wix4 that referenced this pull request Aug 24, 2015

Bug #4792 - feedback updates
Based on feedback from Rob here:
wixtoolset/wix3#268
Using proper resource string for messages + Console instead of
exceptions.
Only checking ProductCode since it is the one true definition of a
unique MSI creation

Conflicts:
	src/tools/melt/MeltStrings.resx
	src/tools/melt/melt.cs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment