Add support for additional Windows SDKs #283

Merged
merged 1 commit into from Aug 22, 2015

Projects

None yet

4 participants

@heaths
Contributor
heaths commented Jul 25, 2015

No description provided.

@barnson barnson added this to the v3.11 milestone Aug 11, 2015
@heaths
Contributor
heaths commented Aug 19, 2015

@barnson, any reason this can't go into 3.10? It's only for initialization. VS2015-only machines can't build without these changes (same for wix4 repo).

@barnson
Member
barnson commented Aug 20, 2015

I'll take a look.

@barnson barnson removed this from the v3.11 milestone Aug 20, 2015
@rseanhall
Member

I just built a Win10/VS2015 VM over the weekend, and I can build without this. Probably had something to do with installing the XP support for C++ option.

@jmcooper8654
Contributor

For what it is worth, I can build without it too. The problem I had with XP C++ support turned out to be an incomplete install of VS 2010. VS 2010 installed without error, but a big chunk of the C/C++ header tree was missing. I grafted the necessary bits on, applied SP1 and all the updates, and all has been golden.

Still, it’s good to be flexible.

John M. Cooper

Leavenworth, KS

From: Sean Hall [mailto:notifications@github.com]
Sent: Wednesday, August 19, 2015 8:52 PM
To: wixtoolset/wix3
Subject: Re: [wix3] Add support for additional Windows SDKs (#283)

I just built a Win10/VS2015 VM over the weekend, and I can build without this. Probably had something to do with installing the XP support for C++ option.


Reply to this email directly or view it on GitHub #283 (comment) . https://github.com/notifications/beacon/AGu1PbiqUWkSk8M4eCskzYuE-uOaJLJDks5opSpcgaJpZM4FfxmR.gif


This email has been checked for viruses by Avast antivirus software.
https://www.avast.com/antivirus

@heaths
Contributor
heaths commented Aug 20, 2015

I've verified that XP support is checked. That's really just the headers and libs, though (well, mainly libs). On several fresh machines I've had to do this. In fact, over the weekend I'm working on another change to let us build votive using the latest VSSDK since it contains all the previous bits. I really don't want to put VS2010 on this machine just to build WiX (and VSSDK2010 requires VS2010; even if you work around the blocking message, all the binaries VSSDK2010 references are installed by VS2010).

@barnson barnson merged commit a25ae12 into wixtoolset:develop Aug 22, 2015
@barnson
Member
barnson commented Aug 22, 2015

I tried it on a Dev14-only VM and OneTimeWixBuildInitialization.proj fails without it. Yet another reason to ship the strong-name signing key...

@heaths heaths deleted the heaths:vs2015 branch Aug 22, 2015
@heaths
Contributor
heaths commented Aug 22, 2015

@barnson The private key is only a result of depending on VS2010. I'll have a PR eventually so that you can actually build Votive without VS2010 SDK as well. All the stuff we need should be in all future versions as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment