New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

* RobMen: WIXBUG:4879 - support x64 folders and bind variables in SWID Tags. #293

Merged
merged 2 commits into from Sep 1, 2015

Conversation

Projects
None yet
4 participants
@firegiantco

firegiantco commented Sep 1, 2015

No description provided.

@@ -118,4 +132,28 @@
</xs:attribute>
</xs:complexType>
</xs:element>

This comment has been minimized.

@barnson

barnson Sep 1, 2015

Member

Why are these now necessary? @Win64 is a string...

@barnson

barnson Sep 1, 2015

Member

Why are these now necessary? @Win64 is a string...

-1 < version.Minor ? version.Minor : 0,
-1 < version.Build ? version.Build : 0,
-1 < version.Revision ? version.Revision : 0);
try

This comment has been minimized.

@barnson

barnson Sep 1, 2015

Member

So a bind-time variable always results in 0.0.0.0?

@barnson

barnson Sep 1, 2015

Member

So a bind-time variable always results in 0.0.0.0?

This comment has been minimized.

@heaths

heaths Sep 1, 2015

Contributor

Worse: 0.0.-1.-1

@heaths

heaths Sep 1, 2015

Contributor

Worse: 0.0.-1.-1

This comment has been minimized.

@robmen

robmen Sep 1, 2015

Member

Turns out the tag is generated twice. First time just to get the size about right and second time to actually get the tag fully populated with access to bind variables. Thus the version may start as "0.0" and be updated to bind values. So it works out okay.

@robmen

robmen Sep 1, 2015

Member

Turns out the tag is generated twice. First time just to get the size about right and second time to actually get the tag fully populated with access to bind variables. Thus the version may start as "0.0" and be updated to bind values. So it works out okay.

barnson added a commit that referenced this pull request Sep 1, 2015

Merge pull request #293 from firegiant/4879-x64-swidtag
* RobMen: WIXBUG:4879 - support x64 folders and bind variables in SWID Tags.

@barnson barnson merged commit be03d56 into wixtoolset:develop Sep 1, 2015

@barnson barnson deleted the firegiant:4879-x64-swidtag branch Sep 1, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment