New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIXBUG:4882 - handle all kinds of bad version strings in WixTagExtension #295

Merged
merged 1 commit into from Sep 2, 2015

Conversation

Projects
None yet
4 participants
@firegiantco

firegiantco commented Sep 2, 2015

Should have added these the first time around.

barnson added a commit that referenced this pull request Sep 2, 2015

Merge pull request #295 from firegiant/4882-fix-tag-version
WIXBUG:4882 - handle all kinds of bad version strings in WixTagExtension

@barnson barnson merged commit 4d019e7 into wixtoolset:develop Sep 2, 2015

@rseanhall

This comment has been minimized.

Show comment
Hide comment
@rseanhall

rseanhall Feb 5, 2016

Member

Can FireGiant port these SWID tag pull requests to v4?

Member

rseanhall commented Feb 5, 2016

Can FireGiant port these SWID tag pull requests to v4?

@barnson

This comment has been minimized.

Show comment
Hide comment
@barnson

barnson Feb 5, 2016

Member

If you're sure you can give up the fun of cherry-picking! :)

Member

barnson commented Feb 5, 2016

If you're sure you can give up the fun of cherry-picking! :)

@rseanhall

This comment has been minimized.

Show comment
Hide comment
@rseanhall

rseanhall Feb 5, 2016

Member

I think you misunderstand, I want to spread around the joy of cherry picking! :)

Member

rseanhall commented Feb 5, 2016

I think you misunderstand, I want to spread around the joy of cherry picking! :)

@barnson

This comment has been minimized.

Show comment
Hide comment
Member

barnson commented Feb 5, 2016

@robmen robmen deleted the firegiant:4882-fix-tag-version branch Mar 22, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment