New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIXBUG:4857 - Fix DTF custom actions in Win10 Apps and Features #312

Merged
merged 2 commits into from Jan 24, 2016

Conversation

Projects
None yet
3 participants
@rseanhall
Member

rseanhall commented Nov 1, 2015

Somehow CreateProcess doesn't work but ShellExecuteEx does.

Also, fix VS2015 native custom action project template to use VS2015 headers and libs.

GetSystemDirectory(szRunDll32Path, MAX_PATH);
wcscat_s(szRunDll32Path, MAX_PATH, L"\\");
wcscat_s(szRunDll32Path, MAX_PATH, rundll32);
wcscat_s(szRunDll32Path, MAX_PATH, szSystemPath);

This comment has been minimized.

@barnson

barnson Jan 24, 2016

Member

At first, a little weird to concatenate to an empty string. But I decided I prefer the way this looks/works.

@barnson

barnson Jan 24, 2016

Member

At first, a little weird to concatenate to an empty string. But I decided I prefer the way this looks/works.

@barnson barnson merged commit f681396 into wixtoolset:develop Jan 24, 2016

robmen added a commit that referenced this pull request Jan 24, 2016

@IvanPalmiero

This comment has been minimized.

Show comment
Hide comment
@IvanPalmiero

IvanPalmiero Sep 26, 2016

I might have a similar issue with the Embedded Chainer. When I uninstall my product from the Add remove programs window or through the original .msi package everything is working fine, but when I try uninstall from the App & Features window of Windows 10, it fails.
I updated my Wix Toolset to 3.11.0.906 and still the uninstall fails when is about to launch the chainer but I don't see anything in the logs.

IvanPalmiero commented Sep 26, 2016

I might have a similar issue with the Embedded Chainer. When I uninstall my product from the Add remove programs window or through the original .msi package everything is working fine, but when I try uninstall from the App & Features window of Windows 10, it fails.
I updated my Wix Toolset to 3.11.0.906 and still the uninstall fails when is about to launch the chainer but I don't see anything in the logs.

@rseanhall

This comment has been minimized.

Show comment
Hide comment
@rseanhall

rseanhall Sep 26, 2016

Member

Please don't discuss issues on pull requests. For support questions like this, please contact the wix-users mailing list. To file a bug, go to https://github.com/wixtoolset/issues/issues.

Based on wixtoolset/issues#5376, it appears Windows is purposefully sandboxing Apps & Features in a way that breaks things like DTF.

Member

rseanhall commented Sep 26, 2016

Please don't discuss issues on pull requests. For support questions like this, please contact the wix-users mailing list. To file a bug, go to https://github.com/wixtoolset/issues/issues.

Based on wixtoolset/issues#5376, it appears Windows is purposefully sandboxing Apps & Features in a way that breaks things like DTF.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment