New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIXBUG:4328 Fix for VSIX Id's having spaces #5

Merged
merged 2 commits into from Apr 21, 2014

Conversation

Projects
None yet
3 participants
@ericschultz
Contributor

ericschultz commented Mar 24, 2014

I have not compiled this because I couldn't get the build system working on my machine. I'd recommend building before merging :)

@robmen

This comment has been minimized.

Show comment
Hide comment
@robmen

robmen Mar 28, 2014

Member

I saw your comments on Twitter. Were you finally able to compile this change?

Member

robmen commented Mar 28, 2014

I saw your comments on Twitter. Were you finally able to compile this change?

@barnson

This comment has been minimized.

Show comment
Hide comment
@barnson

barnson Mar 31, 2014

Member

Do you have a .vsix to test with? Code's fine but I'd feel better knowing someone actually ran the thing once before checkin...

Member

barnson commented Mar 31, 2014

Do you have a .vsix to test with? Code's fine but I'd feel better knowing someone actually ran the thing once before checkin...

@ericschultz

This comment has been minimized.

Show comment
Hide comment
@ericschultz

ericschultz Mar 31, 2014

Contributor

@robmen I did get it building. I've tested and verified VSIX Id's with a space no longer causing installation to fail. It should be good to go :)

Contributor

ericschultz commented Mar 31, 2014

@robmen I did get it building. I've tested and verified VSIX Id's with a space no longer causing installation to fail. It should be good to go :)

robmen added a commit that referenced this pull request Apr 21, 2014

Merge pull request #5 from ericschultz/develop
WIXBUG:4328 Fix for VSIX Id's having spaces

@robmen robmen merged commit 809e1fb into wixtoolset:develop Apr 21, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment