New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add disassembly to bundle and package builders #68

Merged
merged 2 commits into from Jun 15, 2014

Conversation

Projects
None yet
2 participants
@heaths
Contributor

heaths commented Jun 14, 2014

Also handles fact exceptions to avoid an extra break when debugging tests.

Add disassembly to bundle and package builders
Also handles fact exceptions to avoid an extra break when debugging tests.
@@ -100,6 +103,41 @@ public T Build()
}
/// <summary>
/// Disassembles the built item.

This comment has been minimized.

@barnson

barnson Jun 15, 2014

Member

Ugh -- I hate adding duplication. Can we not add it here? I'm still trying to figure out the duplicate between WixTests and WixTestTools...

@barnson

barnson Jun 15, 2014

Member

Ugh -- I hate adding duplication. Can we not add it here? I'm still trying to figure out the duplicate between WixTests and WixTestTools...

This comment has been minimized.

@heaths

heaths Jun 15, 2014

Contributor

If anything I'll take it out of WixTestTools\BuildBase.cs. Nothing really uses those classes that much. It's pretty much all from WixTests\BuildBase.cs-derived classes.

@heaths

heaths Jun 15, 2014

Contributor

If anything I'll take it out of WixTestTools\BuildBase.cs. Nothing really uses those classes that much. It's pretty much all from WixTests\BuildBase.cs-derived classes.

This comment has been minimized.

@heaths

heaths Jun 15, 2014

Contributor

I should also mention that I'm only taking out Disassemble(). The CleanUp was actually consolidated from duplicate in each child class. I can work on getting rid of these or improving on them separately. Seems like an unrelated change to getting this stuff in before the RC build. Many, many test improvements can and need to be made. Git commits shouldn't have such broad scope.

@heaths

heaths Jun 15, 2014

Contributor

I should also mention that I'm only taking out Disassemble(). The CleanUp was actually consolidated from duplicate in each child class. I can work on getting rid of these or improving on them separately. Seems like an unrelated change to getting this stuff in before the RC build. Many, many test improvements can and need to be made. Git commits shouldn't have such broad scope.

This comment has been minimized.

@barnson

barnson Jun 15, 2014

Member

For sure (scope). I just get hives from duplication, even when we're refactoring/fixing the world.

@barnson

barnson Jun 15, 2014

Member

For sure (scope). I just get hives from duplication, even when we're refactoring/fixing the world.

This comment has been minimized.

@heaths

heaths Jun 15, 2014

Contributor

Might I recommend a salve? :)

@heaths

heaths Jun 15, 2014

Contributor

Might I recommend a salve? :)

This comment has been minimized.

@barnson

barnson Jun 15, 2014

Member

You're lucky I already committed. :)

@barnson

barnson Jun 15, 2014

Member

You're lucky I already committed. :)

barnson added a commit that referenced this pull request Jun 15, 2014

Merge pull request #68 from heaths/test
Add disassembly to bundle and package builders

@barnson barnson merged commit c6a9559 into wixtoolset:develop Jun 15, 2014

@heaths heaths deleted the heaths:test branch Jun 15, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment