New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow user custom actions to be independently non-vital #72

Merged
merged 2 commits into from Jun 15, 2014

Conversation

Projects
None yet
2 participants
@heaths
Contributor

heaths commented Jun 14, 2014

Resolves issue 4424 by allowing User elements to be attributed as non-vital so the whole install isn't failed just to add a user to a group (which can be done after install).

heaths added some commits Jun 14, 2014

Allow user custom actions to be independently non-vital
Resolves issue 4424 by allowing User elements to be attributed as non-vital so the whole install isn't failed just to add a user to a group (which can be done after install).
Prevent the current user from being removed
When the test case for issue 4424 uninstalled the MSI package the current user was removed as well.
@@ -3528,6 +3529,17 @@ private void ParseUserElement(XmlNode node, string componentId)
attributes |= UserUpdateIfExists;
}
break;
case "Vital":
if (null == componentId)

This comment has been minimized.

@barnson

barnson Jun 15, 2014

Member

This won't work in the odd case of @id coming after @vital.

@barnson

barnson Jun 15, 2014

Member

This won't work in the odd case of @id coming after @vital.

This comment has been minimized.

@barnson

barnson Jun 15, 2014

Member

Not that it really matters since @id is mandatory anyway...

@barnson

barnson Jun 15, 2014

Member

Not that it really matters since @id is mandatory anyway...

This comment has been minimized.

@barnson

barnson Jun 15, 2014

Member

Post-merge fix?

@barnson

barnson Jun 15, 2014

Member

Post-merge fix?

This comment has been minimized.

@heaths

heaths Jun 15, 2014

Contributor

Looking over this, I don't see the problem. componentId is passed into the method and the User/@Id isn't used in the Vital fragment. Could you clarify?

@heaths

heaths Jun 15, 2014

Contributor

Looking over this, I don't see the problem. componentId is passed into the method and the User/@Id isn't used in the Vital fragment. Could you clarify?

This comment has been minimized.

@barnson

barnson Jun 15, 2014

Member

Sorry, I misread it as User/@id. Ignore.

@barnson

barnson Jun 15, 2014

Member

Sorry, I misread it as User/@id. Ignore.

@barnson barnson merged commit 611c168 into wixtoolset:develop Jun 15, 2014

@heaths heaths deleted the heaths:issue4424 branch Jun 15, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment